Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage typo fixes in PR template #46908

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Discourage typo fixes in PR template #46908

merged 3 commits into from
Dec 23, 2021

Conversation

tjjfvi
Copy link
Contributor

@tjjfvi tjjfvi commented Nov 23, 2021

Wording taken from this comment.

There have been a number of rejected typo fix PRs lately; hopefully this can reduce the amount of typo-fix-rejecting work for the team.

@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 23, 2021
@sandersn sandersn added this to Not started in PR Backlog Dec 7, 2021
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Dec 8, 2021
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll green it, but IMO we should remove:

The same generally applies to other projects.

Because almost all advice for people getting started with OSS is to do this sort of change ( I've given that advice, and I'd give it again in the future ) as it's normally a cheap way to get used to the process

PR Backlog automation moved this from Waiting on reviewers to Needs merge Dec 8, 2021
@RyanCavanaugh
Copy link
Member

I like the spirit but feel the text is a bit strong. How about

** Typo Fixes **
Please don't send a PR solely for the purpose of fixing a typo, unless that typo truly hurts understanding of the text. Each PR represents work for the maintainers, and that work should provide commensurate value.

If you're interested in sending a PR, the issue tracker has many issues marked `help wanted`.

@DanielRosenwasser
Copy link
Member

Maybe a mash-up?

We understand that typo fixes are nice, but when unless these typos
truly make the text harder to read, these typo fixes often ust
add work to the core team without providing much value. If you're interested in
sending a PR, the issue tracker has many issues marked `help wanted`.

Go with Ryan's version unless he likes this one better.

@tjjfvi
Copy link
Contributor Author

tjjfvi commented Dec 10, 2021

Edited to Ryan's version; I'll change it to Daniel's if desired.

Wording taken from [this comment](microsoft#45834 (comment)).

There have been a number of rejected typo fix PRs lately; hopefully this can reduce the amount of typo-fix-rejecting work for the team.
Removed "the same generally applies to other projects" per orta
@orta
Copy link
Contributor

orta commented Dec 23, 2021

Yeah, lets do this 👍🏻

@orta orta merged commit 5cab951 into microsoft:main Dec 23, 2021
PR Backlog automation moved this from Needs merge to Done Dec 23, 2021
@tjjfvi tjjfvi deleted the patch-1 branch December 23, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants