Skip to content

Conversation

@mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Sep 10, 2015

fixes #4727

@DanielRosenwasser DanielRosenwasser changed the title prerocess export import declarations correctelly prerocess export import declarations correctly Sep 10, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you had a helper function like

function scanYieldsSequence(scanner: Scanner, seq: (SyntaxKind | ((kind: SyntaxKind) => boolean))[]) {
    for (let item of seq) {
        let passes = item instanceof Function ?
            item(scanner.scan()) :
            item === scanner.scan()
        if (!passes) {
            return false;
        }
    }

    return true;
}

but it might be overkill

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and yes :)

@DanielRosenwasser
Copy link
Member

👍

mhegazy added a commit that referenced this pull request Sep 10, 2015
prerocess `export import` declarations correctly
@mhegazy mhegazy merged commit 828c37e into release-1.6 Sep 10, 2015
@mhegazy mhegazy deleted the fix4727 branch September 10, 2015 21:19
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants