Cache file existence in synchronizeHostData #48942
Conversation
Saves 1-2% during mui project load (on Linux), mostly by eliminating duplicate non-existence results.
typescript-bot
added
Author: Team
For Uncommitted Bug
|
In very round numbers, I'm seeing |
| } | ||
|
|
||
| function fileExists(fileName: string): boolean { | ||
| // Check this before the file contents cache because it saves computing the Path |
There was a problem hiding this comment.
Is there a reason you are not using changeCompilerHostLikeToUseCache
There was a problem hiding this comment.
I coded it up that way, but found it confusing because of the interaction with HostCache. changeCompilerHostLikeToUseCache covers
readFile, which is already handled, slightly differently, byHostCachefileExistsdirectoryExistscreateDirectory, which would not be usedwriteFile, which would not be usedgetSourceFile, which the caller has to decide to hook up or not and overlaps withHostCache
Some of the nuances, e.g. readFile vs readFileWithCache, felt like they would be confusing in this specialized context.
I believe the HostCache is also used in a few places that consume the language service host, rather than the compiler host.
If you feel strongly about it, I can try to rewrite it in a way that eliminates HostCache altogether, in favor of mutating the host directly.
There was a problem hiding this comment.
I am just wondering if we can get rid of host cache and use our standard method so that if any additions or changes we do in future are not missed? Looked at fileExists , readFile etc in services and its used for duration of program creation so would prefer to use compilerHost and changeCompilerHostLikeToUseCache instead of maintaining our own caches..
| } | ||
|
|
||
| function fileExists(fileName: string): boolean { | ||
| // Check this before the file contents cache because it saves computing the Path |
There was a problem hiding this comment.
I am just wondering if we can get rid of host cache and use our standard method so that if any additions or changes we do in future are not missed? Looked at fileExists , readFile etc in services and its used for duration of program creation so would prefer to use compilerHost and changeCompilerHostLikeToUseCache instead of maintaining our own caches..
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
3 participants
Saves 1-2% during mui project load (on Linux), mostly by eliminating duplicate non-existence results.