Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/services/formatting/formattingScanner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,14 @@

/* @internal */
namespace ts.formatting {
let scanner = createScanner(ScriptTarget.Latest, /*skipTrivia*/ false);

const standardScanner = createScanner(ScriptTarget.Latest, /*skipTrivia*/ false, LanguageVariant.Standard);
const jsxScanner = createScanner(ScriptTarget.Latest, /*skipTrivia*/ false, LanguageVariant.JSX);

/**
* Scanner that is currently used for formatting
*/
let scanner: Scanner;

export interface FormattingScanner {
advance(): void;
isOnToken(): boolean;
Expand All @@ -22,6 +28,8 @@ namespace ts.formatting {
}

export function getFormattingScanner(sourceFile: SourceFile, startPos: number, endPos: number): FormattingScanner {
Debug.assert(scanner === undefined);
scanner = sourceFile.languageVariant === LanguageVariant.JSX ? jsxScanner : standardScanner;

scanner.setText(sourceFile.text);
scanner.setTextPos(startPos);
Expand All @@ -40,12 +48,17 @@ namespace ts.formatting {
isOnToken: isOnToken,
lastTrailingTriviaWasNewLine: () => wasNewLine,
close: () => {
Debug.assert(scanner !== undefined);

lastTokenInfo = undefined;
scanner.setText(undefined);
scanner = undefined;
}
}

function advance(): void {
Debug.assert(scanner !== undefined);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still need these asserts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep them to make sure that contract of interaction with formatting scanner will be kept consistent


lastTokenInfo = undefined;
let isStarted = scanner.getStartPos() !== startPos;

Expand Down Expand Up @@ -138,6 +151,8 @@ namespace ts.formatting {
}

function readTokenInfo(n: Node): TokenInfo {
Debug.assert(scanner !== undefined);

if (!isOnToken()) {
// scanner is not on the token (either advance was not called yet or scanner is already past the end position)
return {
Expand Down Expand Up @@ -245,6 +260,8 @@ namespace ts.formatting {
}

function isOnToken(): boolean {
Debug.assert(scanner !== undefined);

let current = (lastTokenInfo && lastTokenInfo.token.kind) || scanner.getToken();
let startPos = (lastTokenInfo && lastTokenInfo.token.pos) || scanner.getStartPos();
return startPos < endPos && current !== SyntaxKind.EndOfFileToken && !isTrivia(current);
Expand Down
8 changes: 8 additions & 0 deletions tests/cases/fourslash/formatInTsxFiles.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/// <reference path="fourslash.ts"/>

//@Filename: file.tsx
////interface I<T1, T2> {
//// next: I</* */
////}

format.document();