-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ES2024 types, target and fix ES5, ES2017, ES2022 types #58573
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary. |
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
It is strange that ES2024 |
If it was a mistake, I don't think we'd be against fixing it. If you make that change, we can run the extended tests and see how bad it would be. |
This comment was marked as spam.
This comment was marked as spam.
@sandersn Would you review this PR? |
ES2024 released |
Fixes #54636
Refs #54637, #57858
This PR includes the following changes:
ArrayBuffer.prototype.slice
types in ES5SharedArrayBuffer.prototype.slice
types in ES2017ArrayBuffer
/SharedArrayBuffer
types to ES2017Atomics.waitAsync
types from ES2022 to ES2024