Skip to content

Disable conditional exports fallbacks on null values #62483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

Disable conditional exports fallbacks on null values #62483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/compiler/moduleNameResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2812,7 +2812,9 @@ function getLoadModuleFromTargetExportOrImport(extensions: Extensions, state: Mo
const subTarget = (target as MapLike<unknown>)[condition];
const result = loadModuleFromTargetExportOrImport(subTarget, subpath, pattern, key);
if (result) {
traceIfEnabled(state, Diagnostics.Resolved_under_condition_0, condition);
if (result.value) {
traceIfEnabled(state, Diagnostics.Resolved_under_condition_0, condition);
}
traceIfEnabled(state, Diagnostics.Exiting_conditional_exports);
return result;
}
Expand Down Expand Up @@ -2846,7 +2848,7 @@ function getLoadModuleFromTargetExportOrImport(extensions: Extensions, state: Mo
if (state.traceEnabled) {
trace(state.host, Diagnostics.package_json_scope_0_explicitly_maps_specifier_1_to_null, scope.packageDirectory, moduleName);
}
return toSearchResult(/*value*/ undefined);
return { value: undefined };
}
if (state.traceEnabled) {
trace(state.host, Diagnostics.package_json_scope_0_has_invalid_type_for_target_of_specifier_1, scope.packageDirectory, moduleName);
Expand Down
22 changes: 22 additions & 0 deletions ...s/reference/conditionalExportsResolutionFallbackNull(moduleresolution=bundler).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/index.mts(1,16): error TS2307: Cannot find module 'dep' or its corresponding type declarations.


==== /node_modules/dep/package.json (0 errors) ====
{
"name": "dep",
"version": "1.0.0",
"exports": {
".": {
"import": null,
"types": "./dist/index.d.ts"
}
}
}

==== /node_modules/dep/dist/index.d.ts (0 errors) ====
export {};

==== /index.mts (1 errors) ====
import {} from "dep"; // Cannot find module 'dep'.
~~~~~
!!! error TS2307: Cannot find module 'dep' or its corresponding type declarations.
23 changes: 23 additions & 0 deletions ...s/reference/conditionalExportsResolutionFallbackNull(moduleresolution=bundler).trace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
[
"File '/node_modules/dep/dist/package.json' does not exist.",
"Found 'package.json' at '/node_modules/dep/package.json'.",
"======== Resolving module 'dep' from '/index.mts'. ========",
"Explicitly specified module resolution kind: 'Bundler'.",
"Resolving in CJS mode with conditions 'import', 'types'.",
"File '/package.json' does not exist.",
"Loading module 'dep' from 'node_modules' folder, target file types: TypeScript, JavaScript, Declaration, JSON.",
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
"File '/node_modules/dep/package.json' exists according to earlier cached lookups.",
"Entering conditional exports.",
"Matched 'exports' condition 'import'.",
"package.json scope '/node_modules/dep' explicitly maps specifier '.' to null.",
"Exiting conditional exports.",
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
"Searching all ancestor node_modules directories for fallback extensions: JavaScript, JSON.",
"File '/node_modules/dep/package.json' exists according to earlier cached lookups.",
"Entering conditional exports.",
"Matched 'exports' condition 'import'.",
"package.json scope '/node_modules/dep' explicitly maps specifier '.' to null.",
"Exiting conditional exports.",
"======== Module name 'dep' was not resolved. ========"
]
24 changes: 24 additions & 0 deletions ...es/reference/conditionalExportsResolutionFallbackNull(moduleresolution=node16).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
/index.mts(1,16): error TS2307: Cannot find module 'dep' or its corresponding type declarations.


!!! error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
==== /node_modules/dep/package.json (0 errors) ====
{
"name": "dep",
"version": "1.0.0",
"exports": {
".": {
"import": null,
"types": "./dist/index.d.ts"
}
}
}

==== /node_modules/dep/dist/index.d.ts (0 errors) ====
export {};

==== /index.mts (1 errors) ====
import {} from "dep"; // Cannot find module 'dep'.
~~~~~
!!! error TS2307: Cannot find module 'dep' or its corresponding type declarations.
37 changes: 37 additions & 0 deletions ...es/reference/conditionalExportsResolutionFallbackNull(moduleresolution=node16).trace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
[
"File '/node_modules/dep/dist/package.json' does not exist.",
"Found 'package.json' at '/node_modules/dep/package.json'.",
"======== Resolving module 'dep' from '/index.mts'. ========",
"Explicitly specified module resolution kind: 'Node16'.",
"Resolving in ESM mode with conditions 'import', 'types', 'node'.",
"File '/package.json' does not exist.",
"Loading module 'dep' from 'node_modules' folder, target file types: TypeScript, JavaScript, Declaration.",
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
"File '/node_modules/dep/package.json' exists according to earlier cached lookups.",
"Entering conditional exports.",
"Matched 'exports' condition 'import'.",
"package.json scope '/node_modules/dep' explicitly maps specifier '.' to null.",
"Exiting conditional exports.",
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
"File '/node_modules/dep/package.json' exists according to earlier cached lookups.",
"Entering conditional exports.",
"Matched 'exports' condition 'import'.",
"package.json scope '/node_modules/dep' explicitly maps specifier '.' to null.",
"Exiting conditional exports.",
"======== Module name 'dep' was not resolved. ========",
"File '/.ts/package.json' does not exist.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups."
]
24 changes: 24 additions & 0 deletions .../reference/conditionalExportsResolutionFallbackNull(moduleresolution=nodenext).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.
/index.mts(1,16): error TS2307: Cannot find module 'dep' or its corresponding type declarations.


!!! error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.
==== /node_modules/dep/package.json (0 errors) ====
{
"name": "dep",
"version": "1.0.0",
"exports": {
".": {
"import": null,
"types": "./dist/index.d.ts"
}
}
}

==== /node_modules/dep/dist/index.d.ts (0 errors) ====
export {};

==== /index.mts (1 errors) ====
import {} from "dep"; // Cannot find module 'dep'.
~~~~~
!!! error TS2307: Cannot find module 'dep' or its corresponding type declarations.
37 changes: 37 additions & 0 deletions .../reference/conditionalExportsResolutionFallbackNull(moduleresolution=nodenext).trace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
[
"File '/node_modules/dep/dist/package.json' does not exist.",
"Found 'package.json' at '/node_modules/dep/package.json'.",
"======== Resolving module 'dep' from '/index.mts'. ========",
"Explicitly specified module resolution kind: 'NodeNext'.",
"Resolving in ESM mode with conditions 'import', 'types', 'node'.",
"File '/package.json' does not exist.",
"Loading module 'dep' from 'node_modules' folder, target file types: TypeScript, JavaScript, Declaration.",
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
"File '/node_modules/dep/package.json' exists according to earlier cached lookups.",
"Entering conditional exports.",
"Matched 'exports' condition 'import'.",
"package.json scope '/node_modules/dep' explicitly maps specifier '.' to null.",
"Exiting conditional exports.",
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
"File '/node_modules/dep/package.json' exists according to earlier cached lookups.",
"Entering conditional exports.",
"Matched 'exports' condition 'import'.",
"package.json scope '/node_modules/dep' explicitly maps specifier '.' to null.",
"Exiting conditional exports.",
"======== Module name 'dep' was not resolved. ========",
"File '/.ts/package.json' does not exist.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups.",
"File '/.ts/package.json' does not exist according to earlier cached lookups.",
"File '/package.json' does not exist according to earlier cached lookups."
]
26 changes: 26 additions & 0 deletions tests/cases/conformance/moduleResolution/conditionalExportsResolutionFallbackNull.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// @module: esnext
// @moduleResolution: node16,nodenext,bundler
// @traceResolution: true
// @allowJs: true
// @noTypesAndSymbols: true
// @noEmit: true

// We fixed https://github.com/microsoft/TypeScript/issues/50762 for `null` only

// @Filename: /node_modules/dep/package.json
{
"name": "dep",
"version": "1.0.0",
"exports": {
".": {
"import": null,
"types": "./dist/index.d.ts"
}
}
}

// @Filename: /node_modules/dep/dist/index.d.ts
export {};

// @Filename: /index.mts
import {} from "dep"; // Cannot find module 'dep'.
Loading