Skip to content

Conversation

@csigs
Copy link
Member

@csigs csigs commented Nov 21, 2025

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251121203231458 to main with localized lcls

Copilot AI review requested due to automatic review settings November 21, 2025 20:34
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Nov 21, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 21, 2025
Copilot finished reviewing on behalf of csigs November 21, 2025 20:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates localized diagnostic messages across 13 language locales to reflect a change in the allowImportingTsExtensions compiler option validation. The change expands the error message to include rewriteRelativeImportExtensions as a third valid option alongside noEmit and emitDeclarationOnly.

  • Updates the English source message text to reflect the addition of rewriteRelativeImportExtensions option
  • Updates the ItemId from either_noEmit_or_emitDeclarationOnly_is_set_5096 to one_of_noEmit_emitDeclarationOnly_or_rewrite_5096 (truncated due to length)
  • Provides localized translations for all 13 supported languages

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl Turkish localization update for diagnostic message 5096
src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl Russian localization update for diagnostic message 5096
src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl Portuguese (Brazil) localization update for diagnostic message 5096
src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl Polish localization update for diagnostic message 5096
src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl Korean localization update for diagnostic message 5096
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl Japanese localization update for diagnostic message 5096
src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl Italian localization update for diagnostic message 5096
src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl French localization update for diagnostic message 5096
src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl Spanish localization update for diagnostic message 5096
src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl German localization update for diagnostic message 5096
src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl Czech localization update for diagnostic message 5096
src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl Chinese (Traditional) localization update for diagnostic message 5096
src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl Chinese (Simplified) localization update for diagnostic message 5096

<Val><![CDATA[Option 'allowImportingTsExtensions' can only be used when one of 'noEmit', 'emitDeclarationOnly', or 'rewriteRelativeImportExtensions' is set.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Параметр "allowImportingTsExtensions" можно использовать, только если установлен параметр "noEmit" или "emitDeclarationOnly".]]></Val>
<Val><![CDATA[Параметр allowImportingTsExtensions можно использовать только при настройке одного из вариантов: noEmit, emitDeclarationOnly или rewriteRelativeImportExtensions.]]></Val>
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent quotation marks around option names in the Russian translation. While the English source text and most other localizations use single quotes around option names (e.g., 'allowImportingTsExtensions', 'noEmit'), the Russian translation has removed all quotes. For consistency with the source text and other localizations, consider using quotes around the option names: Параметр "allowImportingTsExtensions" можно использовать только при настройке одного из вариантов: "noEmit", "emitDeclarationOnly" или "rewriteRelativeImportExtensions".

Copilot uses AI. Check for mistakes.
<Val><![CDATA[Option 'allowImportingTsExtensions' can only be used when one of 'noEmit', 'emitDeclarationOnly', or 'rewriteRelativeImportExtensions' is set.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Možnost allowImportingTsExtensions se dá použít jenom v případě, že je nastavená možnost noEmitnebo „emitDeclarationOnly“.]]></Val>
<Val><![CDATA[Možnost allowImportingTsExtensions se dá použít jenom v případě, že je nastavená možnost noEmit, emitDeclarationOnly nebo rewriteRelativeImportExtensions.]]></Val>
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent quotation marks around option names in the Czech translation. While the English source text and most other localizations use quotes around option names (e.g., 'allowImportingTsExtensions', 'noEmit'), the Czech translation has removed all quotes. For consistency with the source text and other localizations, consider using quotes around the option names: Možnost „allowImportingTsExtensions" se dá použít jenom v případě, že je nastavená možnost „noEmit", „emitDeclarationOnly" nebo „rewriteRelativeImportExtensions".

Copilot uses AI. Check for mistakes.
@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Nov 22, 2025
@jakebailey jakebailey merged commit fbb051f into main Nov 22, 2025
39 checks passed
@jakebailey jakebailey deleted the lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251121203231458 branch November 22, 2025 00:30
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants