-
Notifications
You must be signed in to change notification settings - Fork 13.1k
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251121203231458 to main #62791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251121203231458 to main #62791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates localized diagnostic messages across 13 language locales to reflect a change in the allowImportingTsExtensions compiler option validation. The change expands the error message to include rewriteRelativeImportExtensions as a third valid option alongside noEmit and emitDeclarationOnly.
- Updates the English source message text to reflect the addition of
rewriteRelativeImportExtensionsoption - Updates the ItemId from
either_noEmit_or_emitDeclarationOnly_is_set_5096toone_of_noEmit_emitDeclarationOnly_or_rewrite_5096(truncated due to length) - Provides localized translations for all 13 supported languages
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Turkish localization update for diagnostic message 5096 |
| src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl | Russian localization update for diagnostic message 5096 |
| src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl | Portuguese (Brazil) localization update for diagnostic message 5096 |
| src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Polish localization update for diagnostic message 5096 |
| src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl | Korean localization update for diagnostic message 5096 |
| src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Japanese localization update for diagnostic message 5096 |
| src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl | Italian localization update for diagnostic message 5096 |
| src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl | French localization update for diagnostic message 5096 |
| src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Spanish localization update for diagnostic message 5096 |
| src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl | German localization update for diagnostic message 5096 |
| src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl | Czech localization update for diagnostic message 5096 |
| src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl | Chinese (Traditional) localization update for diagnostic message 5096 |
| src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl | Chinese (Simplified) localization update for diagnostic message 5096 |
| <Val><![CDATA[Option 'allowImportingTsExtensions' can only be used when one of 'noEmit', 'emitDeclarationOnly', or 'rewriteRelativeImportExtensions' is set.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Параметр "allowImportingTsExtensions" можно использовать, только если установлен параметр "noEmit" или "emitDeclarationOnly".]]></Val> | ||
| <Val><![CDATA[Параметр allowImportingTsExtensions можно использовать только при настройке одного из вариантов: noEmit, emitDeclarationOnly или rewriteRelativeImportExtensions.]]></Val> |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent quotation marks around option names in the Russian translation. While the English source text and most other localizations use single quotes around option names (e.g., 'allowImportingTsExtensions', 'noEmit'), the Russian translation has removed all quotes. For consistency with the source text and other localizations, consider using quotes around the option names: Параметр "allowImportingTsExtensions" можно использовать только при настройке одного из вариантов: "noEmit", "emitDeclarationOnly" или "rewriteRelativeImportExtensions".
| <Val><![CDATA[Option 'allowImportingTsExtensions' can only be used when one of 'noEmit', 'emitDeclarationOnly', or 'rewriteRelativeImportExtensions' is set.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Možnost „allowImportingTsExtensions“ se dá použít jenom v případě, že je nastavená možnost „noEmit“ nebo „emitDeclarationOnly“.]]></Val> | ||
| <Val><![CDATA[Možnost allowImportingTsExtensions se dá použít jenom v případě, že je nastavená možnost noEmit, emitDeclarationOnly nebo rewriteRelativeImportExtensions.]]></Val> |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent quotation marks around option names in the Czech translation. While the English source text and most other localizations use quotes around option names (e.g., 'allowImportingTsExtensions', 'noEmit'), the Czech translation has removed all quotes. For consistency with the source text and other localizations, consider using quotes around the option names: Možnost „allowImportingTsExtensions" se dá použít jenom v případě, že je nastavená možnost „noEmit", „emitDeclarationOnly" nebo „rewriteRelativeImportExtensions".
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251121203231458 to main with localized lcls