break on 'this' type in hasConstraintReferenceTo

[vladima]

fix proposal for #6592, //cc @ahejlsberg

[vladima]

CI build failed because of some random lint errors in files that were not even affected by this PR, looking into this:

src/compiler/types.ts[2497, 14]: missing semicolon
src/compiler/types.ts[2507, 14]: missing semicolon
src/compiler/types.ts[2498, 19]: missing whitespace
src/compiler/types.ts[2498, 20]: missing whitespace
src/compiler/types.ts[2499, 18]: missing whitespace
src/compiler/types.ts[2499, 19]: missing whitespace
src/compiler/types.ts[2500, 20]: missing whitespace
src/compiler/types.ts[2500, 21]: missing whitespace
src/compiler/types.ts[2501, 18]: missing whitespace
src/compiler/types.ts[2501, 19]: missing whitespace
src/compiler/types.ts[2502, 21]: missing whitespace
src/compiler/types.ts[2502, 22]: missing whitespace

[vladima]

pinging @jkillian: it seems that tslint@next has a peer dependency >=1.7.3 || >=1.7.0-dev.20151003 || >=1.8.0-dev which no longer works after version of TypeScript nightly builds was bumped up to 1.9...

[DanielRosenwasser]

I'd rather you move the new check into the body and break with a comment explaining why you need to do this.

[ahejlsberg]

No, the check is fine here with all the other checks.

[jkillian]

Thanks for the heads-up @vladima. I'll check to see that things are working with TS 1.9 nightlies and bump that dependency.

[jkillian]

@vladima Just published a new next release on NPM, hopefully that should fix up the issue here

[DanielRosenwasser]

Thanks @jkillian!

[DanielRosenwasser]

@vladima I requested a re-run on Travis.

[ahejlsberg]

Fix looks good to me.

[vladima]

pinging @mhegazy should it also go to 1.8?

[mhegazy]

We will need to port this to 1.8.