AllowJS files in tsserver when no project is given #7466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hot issue for VSCode. Effectively, with no config file provided, we don't resolve CommonJS modules in JavaScript files.
The issue is that although
allowNonTsExtensionsis set by default,allowJscurrently isn't, and whennodeModuleNameResolveris called, it only resolves files with supportedExtensions. IfallowJsisn't set, then.jsisn't in the set of file extensions it looks for.This is a one line change in
tsserveronly, so should not impact VS. (We should decide ifgetDefaultCompilerOptionsinservices.tsshould set this by default also, but this is the minimal/least risk change for now).