.NET: Fix bugbash issues #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR addresses bugbash issues by refactoring OpenAI agent integration code for better usability and cleaner API design. The changes focus on simplifying how developers configure OpenAI agents and disable response storage functionality.
- Extract response storage configuration into a reusable extension method
- Update sample code to use the new extension method and improve clarity
- Simplify agent creation calls by using named parameters instead of options objects
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ChatOptionsExtensions.cs | Adds new extension method to encapsulate response storage disabling logic |
| AIAgent_With_OpenAIResponseClient.cs | Refactors to use new extension method and removes inline configuration |
| AIAgent_With_OpenAIClient.cs | Updates comment to better describe the agent creation approach |
| AIAgent_With_OpenAIAssistant.cs | Simplifies agent creation by using named parameters instead of options object |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dotnet/samples/GettingStarted/Providers/AIAgent_With_OpenAIResponseClient.cs
Show resolved
Hide resolved
SergeyMenshykh
approved these changes
Aug 20, 2025
…ponseClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
approved these changes
Aug 20, 2025
ReubenBond
pushed a commit
to ReubenBond/agent-framework
that referenced
this pull request
Oct 28, 2025
* Fix bugbash issues * Update dotnet/samples/GettingStarted/Providers/AIAgent_With_OpenAIResponseClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #323
Description
Contribution Checklist