Add optional logging to trace region #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to also log
bghgary
approved these changes
Nov 14, 2025
ryantrem
added a commit
to BabylonJS/JsRuntimeHost
that referenced
this pull request
Nov 14, 2025
This PR depends on microsoft/arcana.cpp#51 - Add a public PerfTrace API that aims to provide a platform agnostic way of capturing perf intervals (just wraps arcana's trace_region). The API can be used purely on the native side, but it also includes helper functions for transferring ownership to JS, or taking ownership from JS. This makes it easy to get perf intervals for operations that start in native and end in JS, or vice versa. - Also add a little more tracing to XmlHttpRequest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mostly adds optional logging to trace_region, but also fixes the missing atomic include in the apple impl.