Improve command notification to show result if toast has closed#6922
Merged
Improve command notification to show result if toast has closed#6922
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
src/Aspire.Dashboard/Model/DashboardCommandExecutor.cs:33
- The new behavior for handling toast display and closing should be covered by tests to ensure it works as expected.
// When a resource command starts a toast is immediately shown.
adamint
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the dashboard UI changes from - #6625. The server changes in that PR need work, but the dashboard UI stuff can be improved now.
When a command is started a toast is immediately shown. It is open for 5 seconds. When the command is finished the toast is updated to show the result.
Previously if the toast had closed because it ran for more than 5 seconds then the UI wouldn't display the result. This PR improves logic so that if the original toast is still open then it is updated and kept open longer. And if it is closed then a new toast is displayed.
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):