Skip to content

Fixed 1290, small changes to output of 1180 and 1320 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimitri-furman merged 3 commits into from
May 4, 2022
Merged

Fixed 1290, small changes to output of 1180 and 1320 #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f77ec0
Added index rebuild statement to output for 1180
dimitri-furman Feb 10, 2022
030ddaf
Added execution timestamp to 1320
dimitri-furman Mar 25, 2022
588d02d
Fixed 1290 (CCI candidates)
dimitri-furman May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions sqldb-tips/get-sqldb-tips-compat-level-100-only.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ SELECT 1320 AS tip_id,
', updateability: ', CAST(DATABASEPROPERTYEX(DB_NAME(), 'Updateability') AS nvarchar(10)),
', logical database GUID: ', rg.logical_database_guid,
', physical database GUID: ', rg.physical_database_guid,
', script execution timestamp (UTC): ', CONVERT(varchar(20), SYSUTCDATETIME(), 120),
@CRLF, @CRLF,
STRING_AGG(
CAST(CONCAT(
Expand Down Expand Up @@ -1018,7 +1019,7 @@ IF EXISTS (SELECT 1 FROM @TipDefinition WHERE tip_id IN (1140) AND execute_indic
WITH allocated_used_space AS
(
SELECT SUM(CAST(size AS bigint) * 8 / 1024.) AS space_allocated_mb,
SUM(CAST(FILEPROPERTY(name, 'SpaceUsed') AS bigint)) / 1024. / 1024 AS space_used_mb
SUM(CAST(FILEPROPERTY(name, 'SpaceUsed') AS bigint)) * 8 / 1024. AS space_used_mb
FROM sys.database_files
WHERE type_desc = 'ROWS'
)
Expand All @@ -1031,7 +1032,7 @@ SELECT 1140 AS tip_id,
@CRLF
)
FROM allocated_used_space
WHERE space_used_mb * 8 / 1024. > @UsedToAllocatedSpaceDbMinSizeMB -- not relevant for small databases
WHERE space_used_mb > @UsedToAllocatedSpaceDbMinSizeMB -- not relevant for small databases
AND
@UsedToAllocatedSpaceThresholdRatio * space_allocated_mb > space_used_mb -- allocated space is more than N times used space
AND
Expand Down Expand Up @@ -2620,7 +2621,13 @@ SELECT STRING_AGG(
', row overflow: ', FORMAT(partition_range_row_overflow_size_mb, 'N'),
', LOB: ', FORMAT(partition_range_lob_size_mb, 'N'),
'), present compression type: ', present_compression_type,
', suggested compression type: ', new_compression_type
', suggested compression type: ', new_compression_type,
', index rebuild statement: ', CONCAT(
'ALTER INDEX ', index_name, ' ON ', schema_name, '.', object_name,
' REBUILD', IIF(partition_range = '1-1', '', CONCAT(' PARTITION = <', partition_range, '>')),
' WITH (', 'DATA_COMPRESSION = ', new_compression_type, ',',
' ONLINE = ON (WAIT_AT_LOW_PRIORITY (MAX_DURATION = 15 MINUTES, ABORT_AFTER_WAIT = SELF)), RESUMABLE = ON);'
)
) AS nvarchar(max)), @CRLF
)
AS details
Expand Down Expand Up @@ -3430,7 +3437,7 @@ ON t.object_id = ius.object_id
i.index_id = ius.index_id
WHERE i.type IN (0,1) -- clustered index or heap
AND
tos.table_size_mb > @CCICandidateMinSizeGB / 1024. -- consider sufficiently large tables only
tos.table_size_mb > @CCICandidateMinSizeGB * 1024. -- consider sufficiently large tables only
AND
t.is_ms_shipped = 0
AND
Expand Down
15 changes: 11 additions & 4 deletions sqldb-tips/get-sqldb-tips.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@ SELECT 1320 AS tip_id,
', updateability: ', CAST(DATABASEPROPERTYEX(DB_NAME(), 'Updateability') AS nvarchar(10)),
', logical database GUID: ', rg.logical_database_guid,
', physical database GUID: ', rg.physical_database_guid,
', script execution timestamp (UTC): ', CONVERT(varchar(20), SYSUTCDATETIME(), 120),
@CRLF, @CRLF,
STRING_AGG(
CAST(CONCAT(
Expand Down Expand Up @@ -1009,7 +1010,7 @@ IF EXISTS (SELECT 1 FROM @TipDefinition WHERE tip_id IN (1140) AND execute_indic
WITH allocated_used_space AS
(
SELECT SUM(CAST(size AS bigint) * 8 / 1024.) AS space_allocated_mb,
SUM(CAST(FILEPROPERTY(name, 'SpaceUsed') AS bigint)) / 1024. / 1024 AS space_used_mb
SUM(CAST(FILEPROPERTY(name, 'SpaceUsed') AS bigint)) * 8 / 1024. AS space_used_mb
FROM sys.database_files
WHERE type_desc = 'ROWS'
)
Expand All @@ -1022,7 +1023,7 @@ SELECT 1140 AS tip_id,
@CRLF
)
FROM allocated_used_space
WHERE space_used_mb * 8 / 1024. > @UsedToAllocatedSpaceDbMinSizeMB -- not relevant for small databases
WHERE space_used_mb > @UsedToAllocatedSpaceDbMinSizeMB -- not relevant for small databases
AND
@UsedToAllocatedSpaceThresholdRatio * space_allocated_mb > space_used_mb -- allocated space is more than N times used space
AND
Expand Down Expand Up @@ -2615,7 +2616,13 @@ SELECT STRING_AGG(
', row overflow: ', FORMAT(partition_range_row_overflow_size_mb, 'N'),
', LOB: ', FORMAT(partition_range_lob_size_mb, 'N'),
'), present compression type: ', present_compression_type,
', suggested compression type: ', new_compression_type
', suggested compression type: ', new_compression_type,
', index rebuild statement: ', CONCAT(
'ALTER INDEX ', index_name, ' ON ', schema_name, '.', object_name,
' REBUILD', IIF(partition_range = '1-1', '', CONCAT(' PARTITION = <', partition_range, '>')),
' WITH (', 'DATA_COMPRESSION = ', new_compression_type, ',',
' ONLINE = ON (WAIT_AT_LOW_PRIORITY (MAX_DURATION = 15 MINUTES, ABORT_AFTER_WAIT = SELF)), RESUMABLE = ON);'
)
) AS nvarchar(max)), @CRLF
)
WITHIN GROUP (ORDER BY object_size_mb DESC, object_name, index_name, partition_range, partition_range_total_size_mb, new_compression_type)
Expand Down Expand Up @@ -3428,7 +3435,7 @@ ON t.object_id = ius.object_id
i.index_id = ius.index_id
WHERE i.type IN (0,1) -- clustered index or heap
AND
tos.table_size_mb > @CCICandidateMinSizeGB / 1024. -- consider sufficiently large tables only
tos.table_size_mb > @CCICandidateMinSizeGB * 1024. -- consider sufficiently large tables only
AND
t.is_ms_shipped = 0
AND
Expand Down