Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@edaena
Copy link
Contributor

@edaena edaena commented Apr 13, 2020

@dennisseah
Copy link
Collaborator

@edaena. I have amended your PR for 3 things.

  1. do not terminate the execute function in the middle of it. We throw error let the final catch block for the error chain
  2. Error messages need to have a statement in past tense on what had happen; followed by a statement in present tense to explain what the user can do to resolve it.
  3. remove unused constants in constants.ts

thanks

@dennisseah dennisseah merged commit 4985ca4 into master Apr 13, 2020
@edaena edaena deleted the edaena-svc-create-err branch April 15, 2020 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error codes, error chain for service create command

5 participants