Skip to content

Clean up nock usage #2677

@mdrichardson

Description

@mdrichardson

This is a tracking issue that I'll address after we decide how we want to an SDK-wide issue that impacts this

Issues

  • nock-helper breaks nock for other tests because it overrides pieces of Node's http module. Caused this issue
  • I believe we call nock.restore() and nock.cleanAll() in ways that will make running tests in parallel very difficult or impossible

To Fix

  1. Remove nock-helper and replace calls to it with the appropriate nock method.
  2. Ensure we don't call nock.cleanAll() and nock.restore() more than absolutely necessary

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: SDKGeneral SDK issues that don't clearly map to other areas (e.g.: helper methods)Size: LThe issue is complex but it is well understood, it will take 4 to 8 days to completebacklogThe issue is out of scope for the current iteration but it will be evaluated in a future release.blockedCurrent progress is blocked on something else.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions