Skip to content

Updated dialog_manager to send EoC code like dialog_extensions. #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Updated dialog_manager to send EoC code like dialog_extensions. #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libraries/botbuilder-dialogs/botbuilder/dialogs/dialog_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
DialogStateManager,
DialogStateManagerConfiguration,
)
from botbuilder.schema import Activity, ActivityTypes
from botbuilder.schema import Activity, ActivityTypes, EndOfConversationCodes
from botframework.connector.auth import (
AuthenticationConstants,
ClaimsIdentity,
Expand Down Expand Up @@ -355,6 +355,9 @@ async def handle_skill_on_turn(
type=ActivityTypes.end_of_conversation,
value=turn_result.result,
locale=turn_context.activity.locale,
code=EndOfConversationCodes.completed_successfully
if turn_result.status == DialogTurnStatus.Complete
else EndOfConversationCodes.user_cancelled,
)
await turn_context.send_activity(activity)

Expand Down
5 changes: 5 additions & 0 deletions libraries/botbuilder-dialogs/tests/test_dialog_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
ActivityTypes,
ChannelAccount,
ConversationAccount,
EndOfConversationCodes,
InputHints,
)
from botframework.connector.auth import AuthenticationConstants, ClaimsIdentity
Expand Down Expand Up @@ -237,6 +238,10 @@ async def test_handles_bot_and_skills(self):
SimpleComponentDialog.eoc_sent.type,
ActivityTypes.end_of_conversation,
)
self.assertEqual(
SimpleComponentDialog.eoc_sent.code,
EndOfConversationCodes.completed_successfully,
)
self.assertEqual(SimpleComponentDialog.eoc_sent.value, "SomeName")
else:
self.assertIsNone(
Expand Down