This repository was archived by the owner on Jan 15, 2025. It is now read-only.
fix luis-cross train does not find imported files with locale #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicshuai
changed the title
feich-ms
reviewed
Apr 23, 2021
feich-ms
reviewed
Apr 23, 2021
packages/luis/test/fixtures/testcases/testImportWithLocale/bin/assistant_core.en-us.lu
Outdated
Show resolved
Hide resolved
boydc2014
approved these changes
Apr 23, 2021
gabog
reviewed
Apr 23, 2021
Contributor
|
@munozemilio this is a fix for adaptive runtime CI/CD, it's been verified, can you help get it in |
added 2 commits
April 23, 2021 22:34
…/botframework-cli into shuwan/fixImportLocale
gabog
reviewed
Apr 23, 2021
gabog
previously requested changes
Apr 23, 2021
Contributor
gabog
left a comment
gabog
left a comment
There was a problem hiding this comment.
I think you missed changing the ignore parameter in the readme files (I still see --ignore there and should be --exclude, right?)
munozemilio
reviewed
Apr 26, 2021
munozemilio
reviewed
Apr 26, 2021
munozemilio
suggested changes
Apr 26, 2021
Contributor
munozemilio
left a comment
munozemilio
left a comment
There was a problem hiding this comment.
Should content be added to the test empty files? Some typos also need to be addressed.
Contributor
Author
|
@munozemilio The empty content test files are from a real Composer bot, I think it is OK to keep them empty. There are import files with locale. So the test covers the code added in this PR. |
munozemilio
reviewed
Apr 27, 2021
| --log Writes out log messages to console | ||
| --exclude Excludes given folders under the input directory, for example, --exclude bin,obj,lib, this will ignore the /bin, /obj, /lib folders under the input path |
Contributor
There was a problem hiding this comment.
FYI This will be overriden by the doc script.
munozemilio
approved these changes
Apr 27, 2021
munozemilio
added a commit
that referenced
this pull request
Apr 28, 2021
* fix import file with locale * simplify test * change folder structures * remove only * add cross train config * fix spelling * modify test * change naming * fix readme * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com>
munozemilio
added a commit
that referenced
this pull request
Apr 28, 2021
* fix import file with locale * simplify test * change folder structures * remove only * add cross train config * fix spelling * modify test * change naming * fix readme * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com>
munozemilio
added a commit
that referenced
this pull request
Apr 28, 2021
* fix luis cross train unable to reference external files (#1181) * init * add path resovle * fix import path resolve issue * add tests * fix lint and unused imports * modify config name * retrigger * refactor Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * fix luis:build write out version in luis setting when the directVersionPublish is not set (#1215) * init * fix tests * retrigger * remove redundent () * up versioned orchestrator-core to 4.13.1 (#1211) * Update package.json Use orchestrator-core v 4.13.1 * Update pnpm-lock.yaml * skip empty lu file, added empty lu file to test * Update orchestratorhelper.ts fixed lint issues * use forward slash for file path in orchestrator.settings.json to be compatible with non windows platform * addressed PR comments Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * fix luis-cross train does not find imported files with locale (#1209) * fix import file with locale * simplify test * change folder structures * remove only * add cross train config * fix spelling * modify test * change naming * fix readme * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> Co-authored-by: Shuai Wang <shuwan@microsoft.com> Co-authored-by: Tien Suwandy <tiens@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1205
In this PR, the import resolver for luis and qna files will find the correct import files based on the locale info.
Suppose we have a.en-us.lu with content
The import resolver will find the b.en-us.lu