Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Fix test for Virtual Assistant on non-Windows machines #1881

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Fix test for Virtual Assistant on non-Windows machines #1881

merged 3 commits into from
Jul 23, 2019

Conversation

@sachabruttin
Copy link
Contributor

Purpose

Close #1880

Changes

n/a

Tests

n/a

Feature Plan

n/a

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@lauren-mills lauren-mills self-assigned this Jul 18, 2019
@darrenj
Copy link
Contributor

darrenj commented Jul 23, 2019

Thanks @sachabruttin

@lauren-mills lauren-mills merged commit dc82a59 into microsoft:master Jul 23, 2019
@pr-triage pr-triage bot added the merged label Jul 23, 2019
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
@sachabruttin @lauren-mills
Fix test for Virtual Assistant on non-Windows machines (#1881)
042e53d 
* Fix Test for non-Windows machines

* Update VA Sample project

* Correct Sample
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lzc850612 lzc850612 Awaiting requested review from lzc850612

@ryanisgrig ryanisgrig Awaiting requested review from ryanisgrig

2 more reviewers

@lauren-mills lauren-mills lauren-mills approved these changes

@darrenj darrenj darrenj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lauren-mills lauren-mills

Labels

merged PR: reviewed-approved PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests doesn't pass when running on non Windows machine

4 participants

@sachabruttin @darrenj @lauren-mills @ryanisgrig