Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Jul 19, 2019

Purpose

What is the context of this pull request? Why is it being done?
There were no tests for utils implementation in Botskills cli tool

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Implement new tests which validate the utils implementation
  • Update the error message of authentication process making it as informative one
  • Remove unused (spawn) method
  • Undo changes on temporal test files during the execution of the tests
  • Fix typos

image

Tests

Is this covered by existing tests or new ones? If no, why not?
We added the following tests:

  • authentication.test.js
  • childProcess.test.js
  • sanitization.test.js
  • validation.test.js

Testing Steps

  1. Go to .\botframework-solutions\tools\botskills
  2. Execute npm install
  3. Execute npm run build
  4. Execute npm run test
  5. Check that all the tests are passing successfully

image

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@Batta32 Batta32 changed the title [Botskills] Implement utils tests [DO NOT MERGE][Botskills] Implement utils tests Jul 22, 2019
@Batta32 Batta32 force-pushed the feature/southworks/botskills/util-tests branch from 03502d8 to 0c04d43 Compare July 22, 2019 12:10
@Batta32 Batta32 changed the title [DO NOT MERGE][Botskills] Implement utils tests [Botskills] Implement utils tests Jul 22, 2019
@darrenj darrenj merged commit 7c18eb1 into master Jul 24, 2019
@pr-triage pr-triage bot added the merged label Jul 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/botskills/util-tests branch July 24, 2019 03:14
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
* Fix the log of the messages

* Fix typo

* Implement validation util tests

* Implement authentication util tests

* Remove unused method

* Implement childProcess util tests

* Undo changes for temporal test files

* Minor fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants