Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@DiegoCardozo94
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?

Update BotBuilder-Libs to Increase the parity between C# and TypeScript:

  • BotBuilder-Solutions
  • BotBuilder-Skills

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Fix EsLint issues in BotBuilder-Libs

Changes in BotBuilder-Skills:

  • microsoftAppCredentialsEx
  • IServiceClientCredentials
  • skillDialog
  • skillHttpTransport
  • activityExtensions
  • Add missing dependency @types/request-promise-native in package.json

Changes in BotBuilder-Solutions:

  • activityExtensions

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

We updated BotBuilder-Libs to have a better functionality and increase the parity with C#. The next step will be to update Virtual-Assistant-Sample and Skill-Sample to continue increasing the parity

Checklist

-

@DiegoCardozo94 DiegoCardozo94 changed the title [TypeScript][BotBuilder Libs] Update functionality of BotBuilder-Skills and BotBuilder-Solutions [DO NOT MERGE][TypeScript][BotBuilder Libs] Update functionality of BotBuilder-Skills and BotBuilder-Solutions Jul 29, 2019
@DiegoCardozo94 DiegoCardozo94 changed the title [DO NOT MERGE][TypeScript][BotBuilder Libs] Update functionality of BotBuilder-Skills and BotBuilder-Solutions [TypeScript][BotBuilder Libs] Update functionality of BotBuilder-Skills and BotBuilder-Solutions Jul 29, 2019
@lauren-mills lauren-mills merged commit 3405cea into master Jul 29, 2019
@pr-triage pr-triage bot added merged and removed PR: unreviewed labels Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/botbuilder-libs/fix-issue branch July 29, 2019 22:23
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
…ls and BotBuilder-Solutions (#1933)

* Update BotBuilder-Libs

* Minor changes in BotBuilder-Libs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants