This repository was archived by the owner on Jun 30, 2022. It is now read-only.
[Power BI] Fix App Insights timespan query that limited all additional timerange parameters #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timerange parameters
darrenj
approved these changes
Aug 5, 2019
|
Should we consider a cherry pick into master for this as it's bug fix? |
|
We can merge into master and then merge down to next after |
|
Seems like this is a lot of changes just for a pbi fix. I think if you create the PR against next, then change to master it pulls in all the next commits |
|
@lauren-mills I changed it back to PR against the next branch, and I can cherry pick the commit to master after. The branch was made off of next so that's why it had all those other changes. |
lzc850612
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
Close #1944
Removed a timespan parameter on the App Insights query, this only provided 7 days of data to Power BI.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
n/a
Tests
Is this covered by existing tests or new ones? If no, why not?
n/a
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
n/a