Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@KayMKM
Copy link
Contributor

@KayMKM KayMKM commented Aug 16, 2019

Purpose

Part 1 of refactor calendar skill.
Refactor state. Split the variables in state to these categories: basic, meeting information, show meeting information, update meeting information.

Changes

refactor CalendarSkillState and change related dialogs.

Tests

Yes

Feature Plan

finish the tasks that listed in #2142

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@KayMKM KayMKM merged commit 496b139 into next Aug 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the yuesu/calendar_refactor_next branch August 19, 2019 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants