Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@DiegoCardozo94
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?
There is a typographical error in 'publish.ps1', there is a condition that looks for a file '.web.config'.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Change .web.config to web.config in the publish.ps1 of the templates

image

Tests

Is this covered by existing tests or new ones? If no, why not?
-

Testing Steps

  1. Create a Virtual Assistant/Skill with the Generator.
  2. In the generated Virtual Assistant or Skill folder, create an empty web.config file.
  3. Open a terminal in that location and execute pwsh.exe -File deployment\scripts\deploy.ps1.
  4. After deployment, execute pwsh.exe -File deployment\scripts\publish.ps1.
  5. Verify that the web.config file is unchanged.

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@darrenj darrenj merged commit cd49dde into master Sep 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/template-va-skill/fix-web-config branch September 24, 2019 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants