Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@dfavretto
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?
In the PR #2323, the Sample was modified and not the Template, the Intro Card shows the word "Kompetenzen" which is the correct translation of Skill into German, but it sounds strange and a Skill is a term that is understood all over the world.

Related to #2322

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
The word Kompetenzen was changed by Skills in the file NewUserGreeting.de.json of the Template.

image

image

Tests

Is this covered by existing tests or new ones? If no, why not?
-

Testing Steps

  1. Create a Virtual Assistant with the Generator, make sure to select the Deutsch language.
  2. In the root of your generated assistant, execute pwsh -File deployment\scripts\deploy.ps1.
  3. Open the Emulator and change the culture to German (using de-de)
  4. Check that the image matches.

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@darrenj darrenj merged commit 9b32ea6 into master Sep 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/template/update-file-newusergreeting branch September 28, 2019 03:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants