Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@dfavretto
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?
The documentation had sample commands of the Botskills using the paramter botName, which has been removed.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Remove the botName parameter from the sample command of the Botskills.

Tests

Is this covered by existing tests or new ones? If no, why not?
-

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@darrenj darrenj merged commit f2fa1d3 into master Oct 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/botskills-documentation/fix-botname-parameter branch October 4, 2019 09:04
ryanisgrig added a commit that referenced this pull request Oct 4, 2019
…2463)

* Add FAQ page and create new help category for FAQ and known issues

* Update faq.md

fixed capitalization

* fixed captialization

* fixed captialization

* Update faq.md

* Fix documentation for botName parameter (#2476)

* Add FAQ page and create new help category for FAQ and known issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants