Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@grav
Copy link
Contributor

@grav grav commented Dec 19, 2024

When migrating an existing app to the stand-alone server, it makes sense to re-use existing deployment keys.

The Rest API already allows for explicitly specifying deployment key, so this PR just adds an optional argument to the deployment add command.

Example usage:

code-push-standalone deployment add my-app prod existing-key-abc123

@grav
Copy link
Contributor Author

grav commented Dec 19, 2024

@microsoft-github-policy-service agree

@grav grav force-pushed the grav/specify-deployment-key branch from 3b598c7 to 7b27e94 Compare December 19, 2024 13:13
@amdrade
Copy link

amdrade commented Dec 21, 2024

+1

@DmitriyKirakosyan
Copy link
Contributor

@grav Thank you for your contribution! I’ve tested your changes, and they work as expected. Could you please update the documentation and the command description to reflect the newly added argument?

@grav
Copy link
Contributor Author

grav commented Dec 30, 2024

@DmitriyKirakosyan Thanks for the feedback. I've added example usage to the CLI configuration and the README.

@grav grav force-pushed the grav/specify-deployment-key branch from 30c7270 to dea9ba7 Compare December 30, 2024 12:02
@lucen-ms lucen-ms merged commit 08e97d7 into microsoft:main Jan 6, 2025
3 checks passed
@lucen-ms
Copy link
Collaborator

lucen-ms commented Jan 6, 2025

Thank you @grav for your contribution.

@grav grav deleted the grav/specify-deployment-key branch January 6, 2025 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants