This repository was archived by the owner on May 20, 2025. It is now read-only.
Check LOGGING env-var for "true" #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOGGING env var should be exlicitly set to "true", in order to log requests. Currently it just needs to be truethy, which doesn't correspond with the docs, OR the current default value in the example .env.local file (where it's "false").
lucen-ms
approved these changes
Feb 12, 2025
Collaborator
|
@grav thank you for your contribution. |
itujo
pushed a commit
to Idea-Maker/code-push-server
that referenced
this pull request
Feb 21, 2025
LOGGING env var should be exlicitly set to "true", in order to log requests. Currently it just needs to be truethy, which doesn't correspond with the the current default value in the example .env.local file (where it's "false"). Explicit "true" is also how other env-vars are checked, eg https://github.com/microsoft/code-push-server/blob/08e97d751620ad7867bb0c9b94633e94f2c01c68/api/script/default-server.ts#L110
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOGGING env var should be exlicitly set to "true", in order to log requests.
Currently it just needs to be truethy, which doesn't correspond with the the current default value in the example .env.local file (where it's "false").
Explicit "true" is also how other env-vars are checked, eg
code-push-server/api/script/default-server.ts
Line 110 in 08e97d7