This repository was archived by the owner on May 20, 2025. It is now read-only.
Deleting release zip on erorr #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/script/command-executor.ts
Outdated
| deleteFileIfTemporary(file); | ||
| }) | ||
| .catch((error): void => { | ||
| deleteFileIfTemporary(file); |
There was a problem hiding this comment.
I would use .finally() instead of calling deleteFileIfTemporary() in two places
There was a problem hiding this comment.
I was going to, but I decided to mirror what you did in the release-react command when deleting the temp folder. Since Promise.prototype.finally isn't standard, I kind of prefer doing this, but I'm happy either way.
|
LGTM! |
lostintangent
added a commit
that referenced
this pull request
Mar 13, 2016
Deleting release zip on erorr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #161 by ensuring that the ZIP generated by the
releasecommand is always deleted, regardless if the release fails (e.g. because the server rejected an identical release).