This repository was archived by the owner on May 20, 2025. It is now read-only.
Improving release-react #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/script/command-executor.ts
Outdated
| } | ||
| } else { | ||
| // Allow the plist prefix to be specified with or without a trailing | ||
| // seperator character, but prescribe the use of a "-" when omitted. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
release-reactcommand in the following ways:--plistFilePrefixparameter by auto-appending a "-" if the provided value doesn't already end in a separator (currently a period or hyphen). In practice, 100% of the files I've seen use a hyphen as a separator, so this change simply conforms to the common convention.After this PR, I think the
release-reactcommand is in a pretty awesome state. However, I can imagine the need for us to add a new--gradlePathparameter to allow specifying where thebuild.gradlefile is in apps that use a non-traditional project layout. We can address that in a future PR if we hear requests for it.