Skip to content

Support Authenticated GitHub Requests in Setup #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Support Authenticated GitHub Requests in Setup #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f14cff
Move CodeQL latest version query behind CLI arg
travisgosselin Dec 7, 2022
d7766e5
Add GitHub authentication for PyGithub with env var GITHUB_TOKEN
travisgosselin Dec 7, 2022
37f7d04
Merge branch 'main' into feature/github-token-support
scovetta Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions container/libs/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
from datetime import datetime, MINYEAR
import os
from datetime import datetime, MINYEAR
from github import Github, GitRelease, Repository, GithubException

def get_latest_github_repo_version(repo):
client = Github()
# check for a github token that may be used alongside the codeql cli to upload github results
# this will limit rate limting 403 errors on checking codeql versions, as the request will be authenticated if possible.
# by default codeql uses env var "GITHUB_TOKEN" to authenticate
# https://codeql.github.com/docs/codeql-cli/manual/github-upload-results/
access_token = os.getenv('GITHUB_TOKEN')
client = Github(access_token) if access_token != None else Github()
repo = client.get_repo(repo)
releases = repo.get_releases()
latest_release = get_latest_github_release(releases)
Expand Down
7 changes: 4 additions & 3 deletions container/setup.py
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@ def setup():
# check version and download the latest version
get_latest_codeql(args)
logger.info("End setup...")

def get_latest_codeql(args):
codeql = CodeQL(CODEQL_HOME)
# what version do we have?
current_installed_version = codeql.get_current_local_version()
logger.info(f'Current codeql version: {current_installed_version}')
# ensure we only query for the latest codeql cli version if we might actually update it
if args.check_latest_cli:
current_installed_version = codeql.get_current_local_version()
logger.info(f'Current codeql version: {current_installed_version}')
latest_online_version = codeql.get_latest_codeql_github_version()
if current_installed_version != latest_online_version.title:
# we got a newer version online, download and install it
Expand Down