Skip to content

[FIX] Prevent rate limiting by changing setup.py to only reach out to the GitHub api to get the latest codeql cli version if args.check_latest_cli is set #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023
Merged

[FIX] Prevent rate limiting by changing setup.py to only reach out to the GitHub api to get the latest codeql cli version if args.check_latest_cli is set #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions container/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,15 @@ def setup():
get_latest_codeql(args)
logger.info("End setup...")
def get_latest_codeql(args):
# what version do we have?
codeql = CodeQL(CODEQL_HOME)
current_installed_version = codeql.get_current_local_version()
logger.info(f'Current codeql version: {current_installed_version}')
latest_online_version = codeql.get_latest_codeql_github_version()
if current_installed_version != latest_online_version.title and args.check_latest_cli:
# we got a newer version online, download and install it
codeql.download_and_install_latest_codeql(latest_online_version)
# what version do we have?
if args.check_latest_cli:
current_installed_version = codeql.get_current_local_version()
logger.info(f'Current codeql version: {current_installed_version}')
latest_online_version = codeql.get_latest_codeql_github_version()
if current_installed_version != latest_online_version.title:
# we got a newer version online, download and install it
codeql.download_and_install_latest_codeql(latest_online_version)
# get the latest queries regardless (TODO: Optimize by storing and checking the last commit hash?)
if args.check_latest_queries:
codeql.download_and_install_latest_codeql_queries()
Expand Down