Handle multiple trailing directory separators #1475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were faced with paths coming from project.assets.json with multiple trailing directory separators:
When normalizing the path we'd remove one of the trailing slashes, but not both. Later on:
We couldn't rebase the path because of the extra trailing slash, so we don't find the real path to the project relative to the scan directory.
As a result we'd report the component as coming from some path outside the scan directory --
Since its outside the scan directory, we couldn't locate the project to probe for the .NET SDK, honoring
global.json. As a result we report the machine-wide SDK version that's preinstalled on the machine running component detection.After the fix this extra project will correctly be mapped and the correct SDK will be reported.