Skip to content

Increased number of default cache entries #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamieMagee merged 1 commit into from
Jan 4, 2023
Merged

Increased number of default cache entries #385

JamieMagee merged 1 commit into from
Jan 4, 2023

Conversation

@amitla1
Copy link
Contributor

@amitla1 amitla1 commented Dec 8, 2022

Related #368

@amitla1 amitla1 requested a review from a team as a code owner December 8, 2022 23:04
@amitla1 amitla1 requested a review from cobya December 8, 2022 23:04
@JamieMagee JamieMagee merged commit a4c44a2 into main Jan 4, 2023
@JamieMagee JamieMagee deleted the users/avannikumar/increaseDefaultPyPiMaxCacheEntries branch January 4, 2023 19:15
@JamieMagee JamieMagee mentioned this pull request Jan 4, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

melotic added a commit that referenced this pull request May 1, 2023
@melotic
docs: correct pip default cache enties
2ceb7d5 
This was updated to 4096 in #385

https://github.com/microsoft/component-detection/blob/804182a508109a36e72f7ecced7d74452c96e405/src/Microsoft.ComponentDetection.Detectors/pip/IPyPiClient.cs#L33
@melotic melotic mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@cobya cobya Awaiting requested review from cobya cobya is a code owner automatically assigned from microsoft/ose-component-detection-maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amitla1 @JamieMagee