Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ docs/ @tinamor

# Tools
containers-toolkit//Public/BuildkitTools.psm1 @profnandaa @billywr @danielGithinji
containers-toolkit/Public/ontainerdTools.psm1 @charitykathure
containers-toolkit/Public/ContainerdTools.psm1 @charitykathure
containers-toolkit/Public/ContainerNetworkTools.psm1 @iankingori
containers-toolkit/Public/NerdctlTools.psm1 @tinamor
64 changes: 0 additions & 64 deletions .github/actions/sign-scripts/action.yaml

This file was deleted.

123 changes: 0 additions & 123 deletions .github/actions/sign-scripts/sign-scripts.ps1

This file was deleted.

41 changes: 18 additions & 23 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,39 +1,34 @@
## PR description

### Github issue/ discussion ()
## PR Description

_related Isuue/discussion(s)_
_What does this PR achieve or fix?_

### Background information
- _Related isuue/discussion(s): Link to the issue or discussion that this PR addresses._
- _Background information: From the reviewer's perspective, what context do they need to understand this PR?_
_Additional information: What does this PR achieve/fix._

_From the perspective of the reviewer, what context do they need to know to understand this PR?_
### TODOs Not Included in This PR

### What does this PR do
_What issues will/should be addressed in follow-up PRs? Link any existing related issues._

_What does this PR achieve/fix._

### TODOs not included in this PR

_What issues will/should be addressed in followup PRs. Link any of these issues if they exist_

### Testing information
### Testing Information

_How to test the changes_

### Relevant links ()
### Relevant Links

_Any links from your research that will help explain the changes_
Any links from your research that help explain the changes

## Checklist

As part of our commitment to engineering excellence, **before** submitting this PR, please make sure:
As part of our commitment to engineering excellence, **before** submitting this PR, please ensure:

- [ ] You've tested this code in both Desktop & Server environments and AMD & ARM64 enviroments (**functional testing**).
- [ ] You've added **unit tests** for new code.
- [ ] You've added/updated documentation in the [cmdlet docs](../docs/About/), [command-reference.md](../docs/command-reference.md) and the [modules help files](../containers-toolkit/en-US/containers-toolkit-help.xml).
- [ ] You've reviewed the PR/code best practices defined in the [CONTRIBUTING.md](../CONTRIBUTING.md).
- [ ] You have tested this code in both Desktop and Server environments, as well as AMD64 and ARM64 environments (**functional testing**).
- [ ] You have added **unit tests** for new code.
- [ ] You have added or updated documentation in the [cmdlet docs](../docs/About/), [command-reference.md](../docs/command-reference.md), and the [modules help files](../containers-toolkit/en-US/containers-toolkit-help.xml).
- [ ] You have reviewed the PR/code best practices defined in the [CONTRIBUTING.md](../CONTRIBUTING.md).

In addition, **after** this PR has been reviewed, please agree to:
In addition, **after** this PR has been reviewed, please ensure:

- [ ] If changes have been made to your PR in the process of addressing comments, please make sure to test again the _final_ version in both AMD and ARM64 environments.
- [ ] Validate your changes have not introduced any regressions.
- [ ] If you make changes while addressing review comments, you test the _final_ version again in both AMD64 and ARM64 environments.
- [ ] You validate that your changes have not introduced any regressions.
22 changes: 14 additions & 8 deletions .github/workflows/ci-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ on:
paths-ignore:
- "docs/**"
- "*.md"
- en-US/**"
- "en-US/**"
- "package.json"
- "package-lock.json"

env:
MODULE_DIR: .\Containers-Toolkit
Expand Down Expand Up @@ -114,6 +116,15 @@ jobs:
$ErrorActionPreference = 'Continue'
${{ env.BUILD_SCRIPTS_DIR }}\run-tests.ps1

# Get failed tests
Write-Host "Getting failed tests from ${{ env.PESTER_RESULTS_DIR }}\Test-Results.xml"
$results = (Select-Xml -Path "${{ env.PESTER_RESULTS_DIR }}\Test-Results.xml" -XPath "//test-case").Node
$failedTests = $results | Where-Object { ($_.success -eq $false) -and ($_.result -ne "Ignored") }
if ($failedTests.Count -gt 0) {
$failedTestsName = ($failedTests | ForEach-Object { $_.name }) -join "`n"
Write-Host "Failed tests:`n$failedTestsName" -Foregroundcolor Red
echo "$failedTestsName" >> $env:GITHUB_STEP_SUMMARY
}
- name: Publish Pester results
uses: actions/upload-artifact@v4
with:
Expand All @@ -133,6 +144,7 @@ jobs:
test-coverage:
needs: pester
runs-on: ubuntu-latest
continue-on-error: true
steps:
- name: Download coverage results artifact
uses: actions/download-artifact@v4
Expand All @@ -159,12 +171,6 @@ jobs:
name: coveragereport # Artifact name
path: coveragereport # Directory containing files to upload

- name: Publish coverage summary
uses: marocchino/sticky-pull-request-comment@v2
continue-on-error: true
with:
path: coveragereport/SummaryGithub.md

- name: Post results
run: |
cat coveragereport/SummaryGithub.md >> $env:GITHUB_STEP_SUMMARY
cat coveragereport/SummaryGithub.md >> $env:GITHUB_STEP_SUMMARY
Loading