Merge pull request #533 from microsoft/psl-code-quality

fix: Fixed all the code quality issues

Author: Roopan-Microsoft

infra/scripts/validate_bicep_params.py

@@ -108,7 +108,9 @@ def parse_parameters_env_vars(json_path: Path) -> dict[str, list[str]]:
         data = json.loads(sanitized)
         params = data.get("parameters", {})
     except json.JSONDecodeError:
-        pass
+        # Keep validation resilient for partially templated/malformed files:
+        # if JSON parsing fails, treat as having no parsable parameters.
+        params = {}
 
     # Walk each top-level parameter and scan its entire serialized value
     # for ${VAR} references from the original text.

src/ContentProcessor/src/libs/agent_framework/agent_framework_helper.py

@@ -143,7 +143,7 @@ def create_client(
         env_file_encoding: str | None = None,
         instruction_role: str | None = None,
     ) -> "AzureOpenAIChatClient":
-        ...
+        pass
 
     @overload
     @staticmethod
@@ -166,7 +166,7 @@ def create_client(
         instruction_role: str | None = None,
         retry_config: RateLimitRetryConfig | None = None,
     ) -> AzureOpenAIChatClientWithRetry:
-        ...
+        pass
 
     @overload
     @staticmethod
@@ -190,7 +190,7 @@ def create_client(
         env_file_path: str | None = None,
         env_file_encoding: str | None = None,
     ) -> "AzureOpenAIAssistantsClient":
-        ...
+        pass
 
     @overload
     @staticmethod
@@ -212,7 +212,7 @@ def create_client(
         env_file_encoding: str | None = None,
         instruction_role: str | None = None,
     ) -> "AzureOpenAIResponsesClient":
-        ...
+        pass
 
     @overload
     @staticmethod
@@ -235,7 +235,7 @@ def create_client(
         instruction_role: str | None = None,
         retry_config: RateLimitRetryConfig | None = None,
     ) -> AzureOpenAIResponseClientWithRetry:
-        ...
+        pass
 
     @overload
     @staticmethod
@@ -252,7 +252,7 @@ def create_client(
         env_file_path: str | None = None,
         env_file_encoding: str | None = None,
     ) -> "AzureAIAgentClient":
-        ...
+        pass
 
     @staticmethod
     def create_client(

src/ContentProcessor/src/libs/agent_framework/azure_openai_response_retry.py

@@ -616,8 +616,15 @@ async def _tail():
                 if callable(close):
                     try:
                         await close()
-                    except Exception:
-                        pass
+                    except Exception as close_exc:
+                        # Best-effort stream cleanup: ignore close failures so we preserve
+                        # the original exception/retry path.
+                        logger.debug(
+                            "[AOAI_RETRY_STREAM] ignoring stream close failure during retry handling: %s",
+                            _format_exc_brief(close_exc)
+                            if isinstance(close_exc, BaseException)
+                            else str(close_exc),
+                        )
 
                 # One-shot retry for context-length failures.
                 if (
@@ -802,8 +809,13 @@ async def _tail():
                 if callable(close):
                     try:
                         await close()
-                    except Exception:
-                        pass
+                    except Exception as close_error:
+                        # Intentionally suppress close-time failures so we do not
+                        # mask the original streaming exception that triggered retry handling.
+                        logger.debug(
+                            "[AOAI_RETRY_STREAM] ignoring stream close failure during error handling",
+                            exc_info=close_error,
+                        )
 
                 # One-shot retry for context-length failures.
                 if (

src/ContentProcessorAPI/app/application.py

@@ -53,6 +53,7 @@ class Application(Application_Base):
 
     def __init__(self):
         super().__init__(env_file_path=os.path.join(os.path.dirname(__file__), ".env"))
+        self.bootstrap()
 
     def initialize(self):
         """Build the FastAPI app, attach middleware, routers, and dependencies.

src/ContentProcessorAPI/app/libs/azure/storage_blob/helper.py

@@ -7,6 +7,7 @@
 retrieve them during downstream pipeline stages.
 """
 
+from azure.core.exceptions import ResourceNotFoundError
 from azure.storage.blob import BlobServiceClient
 
 from app.utils.azure_credential_utils import get_azure_credential
@@ -124,7 +125,8 @@ def delete_blob_and_cleanup(self, blob_name, container_name=None):
         container_client = self._get_container_client(container_name)
         try:
             container_client.delete_blob(blob_name)
-        except Exception:
+        except ResourceNotFoundError:
+            # Blob already absent; continue with folder cleanup checks.
             pass
 
         blobs = container_client.list_blobs()

src/ContentProcessorAPI/app/libs/base/application_base.py

@@ -4,8 +4,10 @@
 """Abstract base for the application bootstrap sequence.
 
 Orchestrates the startup order: load .env → read Azure App Configuration →
-populate AppContext with configuration and credentials → configure logging →
-call the concrete ``initialize()`` implemented by the subclass.
+populate AppContext with configuration and credentials → configure logging.
+The concrete ``initialize()`` hook is invoked
+explicitly via ``bootstrap()``
+after construction is complete.
 """
 
 import inspect
@@ -53,14 +55,13 @@ def initialize(self):
         )
 
     def __init__(self, env_file_path: str | None = None, **data):
-        """Execute the full bootstrap sequence.
+        """Execute base bootstrap setup.
 
         Steps:
             1. Load ``.env`` from *env_file_path* (or derive from subclass location).
             2. Read Azure App Configuration and inject values into ``os.environ``.
             3. Populate ``application_context`` with config and Azure credentials.
             4. Configure Python logging if enabled in config.
-            5. Call ``self.initialize()``.
 
         Args:
             env_file_path: Explicit path to a ``.env`` file (optional).
@@ -103,6 +104,8 @@ def __init__(self, env_file_path: str | None = None, **data):
                 ):
                     logging.getLogger(logger_name).setLevel(azure_level)
 
+    def bootstrap(self):
+        """Run subclass initialization after construction has completed."""
         self.initialize()
 
     def _load_env(self, env_file_path: str | None = None):

src/ContentProcessorAPI/app/libs/base/fastapi_protocol.py

@@ -24,7 +24,7 @@ class FastAPIWithContext(Protocol):
     app_context: AppContext
 
     def include_router(self, *args, **kwargs) -> None:
-        ...
+        pass
 
 
 def add_app_context_to_fastapi(

src/ContentProcessorAPI/app/routers/claimprocessor.py

@@ -166,8 +166,10 @@ async def delete_claim_container(claim_id: str, request: Request = None):
     )
     try:
         claim_processor.delete_claim_container(claim_id=claim_id)
-    except Exception:
-        pass
+    except Exception as ex:
+        # Best-effort cleanup: continue deleting the claim-process record even if
+        # the backing claim container is already missing or cannot be deleted.
+        print(f"Failed to delete claim container for '{claim_id}': {ex}")
 
     batch_process_repository: ClaimBatchProcessRepository = app.app_context.get_service(
         ClaimBatchProcessRepository

src/ContentProcessorWeb/src/Components/Header/Header.tsx

@@ -8,7 +8,7 @@
 
 import React from "react";
 import { useNavigate, useLocation } from "react-router-dom";
-import { useHeaderHooks, Header } from "../../Hooks/useHeaderHooks";
+import { Header } from "../../Hooks/useHeaderHooks";
 import {
   TabList,
   Tab,

src/ContentProcessorWeb/src/Components/UploadContent/UploadFilesModal.tsx

@@ -337,7 +337,7 @@ const UploadFilesModal: React.FC<UploadFilesModalProps> = ({ open, onClose }) =>
     setFileErrors({})
     setUploadCompleted(false);
     setFileSchemas({});
-  }
+  };
   const onCloseHandler = () => {
     resetState();
     onClose();