Skip to content

Commit f5427bc

Browse files
Merge pull request #292 from microsoft/dev
fix: Dev to main merge
2 parents 424cdff + 831527a commit f5427bc

15 files changed

+12695
-4303
lines changed

.github/workflows/azure-dev.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
AZURE_ENV_NAME: ${{ secrets.AZURE_ENV_NAME }}
3030
AZURE_LOCATION: ${{ secrets.AZURE_LOCATION }}
3131
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
32+
AZURE_DEV_COLLECT_TELEMETRY: ${{ vars.AZURE_DEV_COLLECT_TELEMETRY }}
3233

3334
# Step 3: Print the result of the validation
3435
- name: Print result

.github/workflows/deploy.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,16 @@ jobs:
3333
3434
- name: Login to Azure
3535
run: |
36-
az login --service-principal -u ${{ secrets.AZURE_MAINTENANCE_CLIENT_ID }} -p ${{ secrets.AZURE_MAINTENANCE_CLIENT_SECRET }} --tenant ${{ secrets.AZURE_TENANT_ID }}
37-
az account set --subscription ${{ secrets.AZURE_MAINTENANCE_SUBSCRIPTION_ID }}
36+
az login --service-principal -u ${{ secrets.AZURE_CLIENT_ID }} -p ${{ secrets.AZURE_CLIENT_SECRET }} --tenant ${{ secrets.AZURE_TENANT_ID }}
37+
az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }}
3838
3939
- name: Run Quota Check
4040
id: quota-check
4141
run: |
42-
export AZURE_MAINTENANCE_CLIENT_ID=${{ secrets.AZURE_MAINTENANCE_CLIENT_ID }}
42+
export AZURE_CLIENT_ID=${{ secrets.AZURE_CLIENT_ID }}
4343
export AZURE_TENANT_ID=${{ secrets.AZURE_TENANT_ID }}
44-
export AZURE_MAINTENANCE_CLIENT_SECRET=${{ secrets.AZURE_MAINTENANCE_CLIENT_SECRET }}
45-
export AZURE_MAINTENANCE_SUBSCRIPTION_ID="${{ secrets.AZURE_MAINTENANCE_SUBSCRIPTION_ID }}"
44+
export AZURE_CLIENT_SECRET=${{ secrets.AZURE_CLIENT_SECRET }}
45+
export AZURE_SUBSCRIPTION_ID="${{ secrets.AZURE_SUBSCRIPTION_ID }}"
4646
export GPT_MIN_CAPACITY="100"
4747
export AZURE_REGIONS="${{ vars.AZURE_REGIONS }}"
4848
@@ -144,15 +144,15 @@ jobs:
144144
--resource-group ${{ env.RESOURCE_GROUP_NAME }} \
145145
--template-file infra/main.json \
146146
--parameters \
147-
environmentName="${{ env.ENVIRONMENT_NAME }}" \
147+
solutionName="${{ env.ENVIRONMENT_NAME }}" \
148148
enablePrivateNetworking="false" \
149149
secondaryLocation="eastus2" \
150150
contentUnderstandingLocation="WestUS" \
151151
deploymentType="GlobalStandard" \
152152
gptModelName="gpt-4o" \
153153
gptModelVersion="2024-08-06" \
154154
gptDeploymentCapacity="30" \
155-
aiDeploymentsLocation="${{ env.AZURE_LOCATION }}" \
155+
aiServiceLocation="${{ env.AZURE_LOCATION }}" \
156156
tags="{'CreatedBy':'Pipeline', 'SecurityControl':'Ignore','Purpose':'Deploying and Cleaning Up Resources for Validation','CreatedDate':'$current_date'}" \
157157
--query "properties.outputs" -o json); then
158158
echo "❌ Deployment failed. See logs above."
@@ -301,8 +301,8 @@ jobs:
301301

302302
- name: Login to Azure
303303
run: |
304-
az login --service-principal -u ${{ secrets.AZURE_MAINTENANCE_CLIENT_ID }} -p ${{ secrets.AZURE_MAINTENANCE_CLIENT_SECRET }} --tenant ${{ secrets.AZURE_TENANT_ID }}
305-
az account set --subscription ${{ secrets.AZURE_MAINTENANCE_SUBSCRIPTION_ID }}
304+
az login --service-principal -u ${{ secrets.AZURE_CLIENT_ID }} -p ${{ secrets.AZURE_CLIENT_SECRET }} --tenant ${{ secrets.AZURE_TENANT_ID }}
305+
az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }}
306306
307307
- name: Delete Bicep Deployment
308308
if: always()
@@ -459,7 +459,7 @@ jobs:
459459
460460
echo "Processing KeyVault: $keyvault_name"
461461
# Check if the KeyVault is soft-deleted
462-
deleted_vaults=$(az keyvault list-deleted --query "[?name=='$keyvault_name']" -o json --subscription ${{ secrets.AZURE_MAINTENANCE_SUBSCRIPTION_ID }})
462+
deleted_vaults=$(az keyvault list-deleted --query "[?name=='$keyvault_name']" -o json --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }})
463463
464464
# If the KeyVault is found in the soft-deleted state, purge it
465465
if [ "$(echo "$deleted_vaults" | jq length)" -gt 0 ]; then

.github/workflows/test-automation.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ jobs:
3131

3232
- name: Login to Azure
3333
run: |
34-
az login --service-principal -u ${{ secrets.AZURE_MAINTENANCE_CLIENT_ID }} -p ${{ secrets.AZURE_MAINTENANCE_CLIENT_SECRET }} --tenant ${{ secrets.AZURE_TENANT_ID }}
35-
az account set --subscription ${{ secrets.AZURE_MAINTENANCE_SUBSCRIPTION_ID }}
34+
az login --service-principal -u ${{ secrets.AZURE_CLIENT_ID }} -p ${{ secrets.AZURE_CLIENT_SECRET }} --tenant ${{ secrets.AZURE_TENANT_ID }}
35+
az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }}
3636
3737
- name: Install dependencies
3838
run: |

azure.yaml

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,30 @@ metadata:
1111
name: content-processinge@1.0
1212

1313
hooks:
14-
postprovision:
14+
postdeploy:
1515
posix:
1616
shell: sh
17-
run: sed -i 's/\r$//' ./infra/scripts/post_deployment.sh; ./infra/scripts/post_deployment.sh
17+
run: |
18+
echo "🧭 Web App Details:"
19+
echo "✅ Name: $CONTAINER_WEB_APP_NAME"
20+
echo "🌐 Endpoint: https://$CONTAINER_WEB_APP_FQDN"
21+
echo "🔗 Portal URL: https://portal.azure.com/#resource/subscriptions/$AZURE_SUBSCRIPTION_ID/resourceGroups/$AZURE_RESOURCE_GROUP/providers/Microsoft.App/containerApps/$CONTAINER_WEB_APP_NAME"
22+
23+
echo "🧭 API App Details:"
24+
echo "✅ Name: $CONTAINER_API_APP_NAME"
25+
echo "🌐 Endpoint: https://$CONTAINER_API_APP_FQDN"
26+
echo "🔗 Portal URL: https://portal.azure.com/#resource/subscriptions/$AZURE_SUBSCRIPTION_ID/resourceGroups/$AZURE_RESOURCE_GROUP/providers/Microsoft.App/containerApps/$CONTAINER_API_APP_NAME"
1827
interactive: true
1928
windows:
2029
shell: pwsh
21-
run: ./infra/scripts/post_deployment.ps1
30+
run: |
31+
Write-Host "🧭 Web App Details:"
32+
Write-Host "✅ Name: $env:CONTAINER_WEB_APP_NAME"
33+
Write-Host "🌐 Endpoint: https://$env:CONTAINER_WEB_APP_FQDN"
34+
Write-Host "🔗 Portal URL: https://portal.azure.com/#resource/subscriptions/$env:AZURE_SUBSCRIPTION_ID/resourceGroups/$env:AZURE_RESOURCE_GROUP/providers/Microsoft.App/containerApps/$env:CONTAINER_WEB_APP_NAME" -ForegroundColor Cyan
35+
36+
Write-Host "🧭 API App Details:"
37+
Write-Host "✅ Name: $env:CONTAINER_API_APP_NAME"
38+
Write-Host "🌐 Endpoint: https://$env:CONTAINER_API_APP_FQDN"
39+
Write-Host "🔗 Portal URL: https://portal.azure.com/#resource/subscriptions/$env:AZURE_SUBSCRIPTION_ID/resourceGroups/$env:AZURE_RESOURCE_GROUP/providers/Microsoft.App/containerApps/$env:CONTAINER_API_APP_NAME" -ForegroundColor Cyan
2240
interactive: true

docs/ConfigureAppAuthentication.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ We will add Microsoft Entra ID as an authentication provider to API and Web Appl
1313

1414
1. Add Authentication Provider in Web Application
1515

16-
- Go to deployed Container App and select `ca-cps-<randomname>-web` and click **Add Identity Provider** button in Authentication.
16+
- Go to deployed Container App and select `ca-<randomname>-web` and click **Add Identity Provider** button in Authentication.
1717
![add_auth_provider_web_1](./images/add_auth_provider_web_1.png)
1818

1919
- Select **Microsoft** and set **Client secret expiration**, then click **Add** button.
@@ -29,7 +29,7 @@ We will add Microsoft Entra ID as an authentication provider to API and Web Appl
2929

3030
1. Add Authentication Provider in API Service
3131

32-
- Go to deployed Container App and select `ca-cps-<randomname>-api` and click **Add Identity Provider** button in Authentication.
32+
- Go to deployed Container App and select `ca-<randomname>-api` and click **Add Identity Provider** button in Authentication.
3333
![add_auth_provider_api_1](./images/add_auth_provider_api_1.png)
3434

3535
- Select **Microsoft** and set **Client secret expiration**.
@@ -42,7 +42,7 @@ We will add Microsoft Entra ID as an authentication provider to API and Web Appl
4242

4343
1. Set Redirect URI in Single Page Application Platform
4444

45-
- Go to deployed Container App `ca-cps-<randomname>-web` and select **Authentication** menu, then select created Application Registration.
45+
- Go to deployed Container App `ca-<randomname>-web` and select **Authentication** menu, then select created Application Registration.
4646
![configure_app_registration_web_1](./images/configure_app_registration_web_1.png)
4747

4848
- Select **Authentication**, then select **+ Add a platform** menu.
@@ -51,15 +51,15 @@ We will add Microsoft Entra ID as an authentication provider to API and Web Appl
5151
- Select **Single-page application**.
5252
![configure_app_registration_web_3](./images/configure_app_registration_web_3.png)
5353

54-
- Add Container App `ca-cps-<randomname>-web`'s URL.
54+
- Add Container App `ca-<randomname>-web`'s URL.
5555
![configure_app_registration_web_4](./images/configure_app_registration_web_4.png)
5656

5757
- You may get this URL from here in your Container App.
5858
![configure_app_registration_web_5](./images/configure_app_registration_web_5.png)
5959

6060
2. Add Permission and Grant Permission
6161

62-
- Add Permission for API application. Select **+ Add a permission** button, then search API application with name `ca-cps-<randomname>-api`.
62+
- Add Permission for API application. Select **+ Add a permission** button, then search API application with name `ca-<randomname>-api`.
6363
![configure_app_registration_web_6](./images/configure_app_registration_web_6.png)
6464
![configure_app_registration_web_7](./images/configure_app_registration_web_7.png)
6565

@@ -86,7 +86,7 @@ We will add Microsoft Entra ID as an authentication provider to API and Web Appl
8686

8787
1. Grab Scope Name for Impersonation
8888

89-
- Go to deployed Container App `ca-cps-<randomname>-api` and select **Authentication** menu, then select created Application Registration.
89+
- Go to deployed Container App `ca-<randomname>-api` and select **Authentication** menu, then select created Application Registration.
9090
![configure_app_registration_api_1](./images/configure_app_registration_api_1.png)
9191

9292
- Select **Expose an API** in the left menu. Copy the Scope name, then paste it in some temporary place.
@@ -95,7 +95,7 @@ We will add Microsoft Entra ID as an authentication provider to API and Web Appl
9595

9696
## Step 4: Add Web Application's Client Id to Allowed Client Applications List in API Application Registration
9797

98-
1. Go to the deployed Container App `ca-cps-<randomname>-api`, select **Authentication**, and then click **Edit**.
98+
1. Go to the deployed Container App `ca-<randomname>-api`, select **Authentication**, and then click **Edit**.
9999
![add_client_id_to_api_1](./images/add_client_id_to_api_1.png)
100100

101101
2. Select **Allow requests from specific client applications**, then click the **pencil** icon to add the Client Id.

0 commit comments

Comments
 (0)