Fix build #373
Fix build #373
Conversation
|
Thanks! We hadn't got around to getting that building after moving it over from xlang. |
vsix/vsix.csproj
Outdated
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Content Include="LICENSE"> | ||
| <Content Include="..\LICENSE"> |
There was a problem hiding this comment.
this doesn't work (when tested with resulting vsix). a limitation of vsix creation - the LICENSE file must be copied from parent (where it's shared by Microsoft.Windows.CppWinRT.nuspec) and .gitignored to not be checked in.
| <Error Condition="'$(NatvisDirx86)' == ''" Text="The project must be supplied with a NatvisDirx86 property value" /> | ||
| <Error Condition="'$(NatvisDirx64)' == ''" Text="The project must be supplied with a NatvisDirx64 property value" /> | ||
| <Error Condition="'$(NupkgDir)' == ''" Text="The project must be supplied with a NupkgDir property value" /> | ||
| <Copy SourceFiles="..\LICENSE" DestinationFolder="$(MSBuildProjectDirectory)" /> |
There was a problem hiding this comment.
this needs to stay - see above
| @@ -0,0 +1,25 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
@kennykerr - we can take this, but it will probably need to be modified to support build pipeline
There was a problem hiding this comment.
I'd rather just get the build up and running in one step. Might be simpler to close this PR (without merging) and just fix it all together (along with the internal build).
| <copyright>© Microsoft Corporation. All rights reserved.</copyright> | ||
| <license type="file">LICENSE</license> | ||
| <projectUrl>https://github.com/Microsoft/xlang/tree/master/src/package/cppwinrt/nuget</projectUrl> | ||
| <iconUrl>https://aka.ms/cppwinrt.ico</iconUrl> |
There was a problem hiding this comment.
Since iconUrl is deprecated, can you replace with an icon element pointing to vsix/cppwinrt.ico, and add that file to the nuspec?
Targets marked as Before=Build are run *after* the build has finished, as the DependsOn targets for are run first, and they do all the work.
Visual Studio will mangle manual formatting on save when not using the SDK-style project system. That is what happened with this line.
This batch file creates the NuGet package, and downloads NuGet.exe if required.
Since the URL in the tag 404s, I have not included a replacement icon file in the package.
This reverts commit 1140243.
|
Thanks William! |
3 participants
While trying to build the VSIX project to prepare another PR, I found and fixed approximately one metric crap-ton of build issues. It works for me now; I also added a quality-of-life batch file that builds the NuGet package. Enjoy!