add try_get_activation_factory overloads that take the runtimeclass name #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottj1s
approved these changes
Oct 17, 2020
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
kennykerr
reviewed
Oct 19, 2020
kennykerr
reviewed
Oct 19, 2020
kennykerr
reviewed
Oct 19, 2020
kennykerr
reviewed
Oct 19, 2020
kennykerr
reviewed
Oct 19, 2020
kennykerr
reviewed
Oct 19, 2020
kennykerr
requested changes
Oct 19, 2020
Collaborator
kennykerr
left a comment
kennykerr
left a comment
There was a problem hiding this comment.
Looks good - just a few comments. Generally, the std::string_view should be avoided for systems programming. We do support it, but we should avoid using it any more than necessary as it is not strictly safe and param::hstring gives us more freedom to distance ourselves from it in future.
kennykerr
reviewed
Oct 19, 2020
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a design pattern "extension classes" that uses runtimeclasses as extensions. The class names are discovered at runtime, so we need to be able to specify them to the activation functions. this adds that support.