Skip to content

Fix problem with lineno being none when generating traceback #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix problem with lineno being none when generating traceback #1750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2809b92
Fix problem with lineno being none when generating traceback
rchiodo Dec 2, 2024
5ef7e20
Improve multiline statement handling in stack summary
rchiodo Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,12 +1523,22 @@ def build_exception_info_response(dbg, thread_id, thread, request_seq, set_addit
if IS_PY311_OR_GREATER:
stack_summary = traceback.StackSummary()
for filename_in_utf8, lineno, method_name, line_text, line_col_info in frames[-max_frames:]:
frame_summary = traceback.FrameSummary(filename_in_utf8, lineno, method_name, line=line_text)
if line_col_info is not None:
frame_summary.end_lineno = line_col_info.end_lineno
frame_summary.colno = line_col_info.colno
frame_summary.end_colno = line_col_info.end_colno
stack_summary.append(frame_summary)
# End line might mean that we have a multiline statement.
if line_col_info.end_lineno is not None and lineno < line_col_info.end_lineno:
line_text = "\n".join(linecache.getlines(filename_in_utf8)[lineno : line_col_info.end_lineno + 1])
frame_summary = traceback.FrameSummary(
filename_in_utf8,
lineno,
method_name,
line=line_text,
end_lineno=line_col_info.end_lineno,
colno=line_col_info.colno,
end_colno=line_col_info.end_colno)
stack_summary.append(frame_summary)
else:
frame_summary = traceback.FrameSummary(filename_in_utf8, lineno, method_name, line=line_text)
stack_summary.append(frame_summary)

stack_str = "".join(stack_summary.format())

Expand Down
Loading