Send exit message before process is replaced. WIP #865 #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int19h
reviewed
Apr 1, 2022
|
|
||
| @overrides(NetCommandFactory.make_process_about_to_be_replaced_message) | ||
| def make_process_about_to_be_replaced_message(self): | ||
| event = ExitedEvent(ExitedEventBody(-1, reason="processReplaced")) |
Contributor
There was a problem hiding this comment.
Since we're adding a custom property to a standard message, let's do some namespacing here to prevent future conflicts - something like "pydevd.reason".
int19h
approved these changes
Apr 1, 2022
Contributor
|
@fabioz Is it good to merge? |
Collaborator
Author
|
I just need to do that change you asked for... I had to run some unforeseen errands here today and I wasn't able to do this and the other issue related to the attach (I'll put back the hours during the remaining of the month -- my plan is doing that change tomorrow and merging it). |
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
Author
|
I changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.