Skip to content

Throw CompositeTaskFailedException for context.allOf #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 22, 2022
Merged

Throw CompositeTaskFailedException for context.allOf #86

merged 7 commits into from
Sep 22, 2022

Conversation

shreyas-gopalakrishna
Copy link
Member

TaskOrchestrationContext.allOf should throw TaskFailureException instead of RuntimeException

  • code changes
  • unit tests
  • documentation changes

resolves #54

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

shreyas-gopalakrishna
shreyas-gopalakrishna commented Sep 16, 2022
View reviewed changes
cgillum
cgillum reviewed Sep 16, 2022
View reviewed changes
cgillum
cgillum reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts

cgillum
cgillum reviewed Sep 20, 2022
View reviewed changes
cgillum
cgillum reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're very close on this one! There are a couple changes we should make to the JavaDoc comments and one suggested change about the organization of the inner exceptions.

@shreyas-gopalakrishna shreyas-gopalakrishna marked this pull request as ready for review September 21, 2022 23:17
cgillum
cgillum reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more thing I noticed in my final pass through the code.

cgillum
cgillum approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for doing this work!

@shreyas-gopalakrishna shreyas-gopalakrishna merged commit 921f5ff into main Sep 22, 2022
@shreyas-gopalakrishna shreyas-gopalakrishna deleted the shreyasg/composite-task branch September 22, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgillum cgillum cgillum approved these changes

@kaibocai kaibocai kaibocai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TaskOrchestrationContext.allOf should throw TaskFailureException instead of RuntimeException

3 participants

@shreyas-gopalakrishna @cgillum @kaibocai