Skip to content

Conversation

@kaibocai
Copy link
Member

Issue describing the changes in this PR

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Release durabletask-azure-functions 1.0.1

@kaibocai kaibocai requested a review from cgillum December 13, 2022 02:52
@cgillum
Copy link
Member

cgillum commented Dec 13, 2022

@kaibocai isn't there another change we need to make, such as changing the build dependencies?

Also, since we're making a new release anyways, can we also approve and merge this PR, which has an important JavaDoc fix? #98

@kaibocai
Copy link
Member Author

I am adding the missing compileOnly dependency to the pom file generated by gradle manually, just as I did for durabletask-client. I will update the gradle file to using script to generate the compileOnly dependency in the pom file.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn’t realize we were doing this manually. Let’s definitely look into automating this for future releases.

@kaibocai kaibocai merged commit d8f6642 into main Dec 13, 2022
@kaibocai kaibocai deleted the kaibocai/durabletask-azure-functions-1.0.1 branch December 13, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants