Skip to content

Fix bug in ETW trace code for AcquiredAppLock #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Fix bug in ETW trace code for AcquiredAppLock #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions src/DurableTask.SqlServer/Logging/DefaultEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,35 +61,14 @@ public void AcquiredAppLock(
string AppName,
string ExtensionVersion)
{
this.AcquiredAppLockCore(
this.WriteEvent(
EventIds.AcquiredAppLock,
StatusCode,
LatencyMs,
AppName,
ExtensionVersion);
}

[NonEvent]
unsafe void AcquiredAppLockCore(int eventId, int statusCode, long latencyMs, string appName, string extensionVersion)
{
// This needs to be done manually because the built-in WriteEvent(int, long, long) overload will overwrite data (as shown in testing)
fixed (char* appNamePtr = appName)
fixed (char* extensionVersionPtr = extensionVersion)
{
EventData* data = stackalloc EventData[4];
data[0].DataPointer = (IntPtr)(&statusCode);
data[0].Size = sizeof(int);
data[1].DataPointer = (IntPtr)(&latencyMs);
data[1].Size = sizeof(long);
data[2].DataPointer = (IntPtr)appNamePtr;
data[2].Size = (appName.Length + 1) + 2;
data[3].DataPointer = (IntPtr)extensionVersionPtr;
data[3].Size = (extensionVersion.Length + 1) + 2;

this.WriteEventCore(eventId, 2, data);
}
}

[Event(EventIds.CheckpointStarting, Level = EventLevel.Informational)]
public void CheckpointStarting(
string Name,
Expand Down
Loading