Reduce entity context exposure #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the entity context management in the orchestration worker by simplifying how OrchestrationEntityContext is initialized and removing unnecessary state tracking.
Key Changes:
- Moved
OrchestrationEntityContextinitialization from_OrchestrationExecutor.execute()to_RuntimeOrchestrationContext.__init__() - Removed the unused
_entity_statefield from_OrchestrationExecutor - Removed the
entity_contextparameter from_RuntimeOrchestrationContext.__init__()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
berndverst
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the entity context to a property on _OrchestrationExecutor is both unnecessary and introduces the possibility of clobbering or race conditions - addresses this by reducing scope to _RuntimeOrchestrationContext