Skip to content

Conversation

chiuam
Copy link
Contributor

@chiuam chiuam commented Feb 8, 2023

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Similar to #1611, we want to show scroll indicator only if content overflows/scrollbar is present. This change adopts the same logic where vertical/horizontal scroll indicator props are enabled if maxHeight/maxWidth is set respectively.

Verification

Before After
before after

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@chiuam chiuam requested a review from a team as a code owner February 8, 2023 16:35
@chiuam chiuam merged commit 94412e5 into microsoft:main Feb 8, 2023
@chiuam chiuam deleted the menu-scrollview-props branch February 8, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants