rfc: High Contrast theme on Windows#17465
Merged
miroslavstastny merged 2 commits intomicrosoft:masterfrom Apr 20, 2021
Merged
Conversation
Contributor
|
nit: maybe have an |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 25cac70:
|
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9a01ff085821286d7b684cb37a5a83eb195d56a7 (build) |
jurokapsiar
reviewed
Mar 17, 2021
| } | ||
| } | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
depending on if we implement system colors for react and react-northstar we might need to ship a black HC theme as well - due to compatibility reasons. It might of course be easier to just implement system colors in both of these flavors of Fluent UI, but we need to make a decision on that and understand implications for the consumers.
| --global-color-hc-disabled: GrayText; | ||
| --global-color-hc-selected: Highlight; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
It's probably out of scope, but can we make a prototype with makeStyles() for this to see how it fits into current approach?
layershifter
approved these changes
Mar 19, 2021
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
I don't have any comments, I think that it's important to handle input from OS settings in this case 👍
kolaps33
reviewed
Mar 25, 2021
miroslavstastny
added a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
* rfc: High Contrast theme on Windows * move images to assets, use all 8 system colors, discuss non-Windows systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC describing High Contrast theme honouring Windows HC settings.
View the doc: https://github.com/miroslavstastny/fluentui/blob/a8d647fa29aac052a212a1049a2bcb4e084825d8/rfcs/high-contrast-theme.md