[minor breaking change] Consolidate exception handling so tests can capture the right exception #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbekoe
reviewed
Jan 8, 2018
Contributor
derekbekoe
left a comment
derekbekoe
left a comment
There was a problem hiding this comment.
This is a minor breaking change so would require a minor version bump.
LGTM though if it would help in az.
knack/cli.py
Outdated
| def exception_handler(self, ex): # pylint: disable=no-self-use | ||
| """ The default exception handler for unknown CLI exceptions. """ | ||
| logger.exception(ex) | ||
| """ The default exception handler""" |
Contributor
There was a problem hiding this comment.
nit: can you add a space after handler?
Contributor
|
Made change for ya. I will merge it when the CI passes. |
Contributor
|
@derekbekoe do you approve this? |
derekbekoe
changed the title
derekbekoe
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is one of the options to address test breaks tracked by Azure/azure-cli#5032
The other option is to have test sdk workaround by adding a new patch, but we still need an extraction here say, to a method, so tests can mock.
//CC @troydai @tjprescott @derekbekoe