Skip to content

Add Azure Managed Lustre Filesystem Check Subnet Size#111

Merged
alzimmermsft merged 1 commit intomicrosoft:mainfrom
wolfgang-desalvador:wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize
Oct 6, 2025
Merged

Add Azure Managed Lustre Filesystem Check Subnet Size#111
alzimmermsft merged 1 commit intomicrosoft:mainfrom
wolfgang-desalvador:wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize

Conversation

@wolfgang-desalvador
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the following Azure Managed Lustre commands:

  • azmcp-azuremanagedlustre-filesystem-check-subnet-size: Get information about Azure Managed Lustre SKU [#110]

GitHub issue number?

Relates to:

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
    • Spelling check passes: .\eng\common\spelling\Invoke-Cspell.ps1
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated README.md documentation
    • Updated command list in /docs/azmcp-commands.md
    • Updated test prompts in /docs/e2eTestPrompts.md
    • For new or modified tool descriptions, ran the eng/tools/ToolDescriptionEvaluator tool and obtained a result >= 0.4

Copilot AI review requested due to automatic review settings September 2, 2025 20:31
@wolfgang-desalvador wolfgang-desalvador requested a review from a team as a code owner September 2, 2025 20:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Azure Managed Lustre command check-subnet-size that validates whether a subnet can host an Azure Managed Lustre filesystem for a given SKU and size. The command helps users verify subnet capacity before attempting to create AMLFS instances.

Key changes:

  • Implements subnet validation logic for AMLFS deployments
  • Adds comprehensive unit and live tests for the new functionality
  • Updates documentation and command registration

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
FileSystemCheckSubnetCommand.cs Core command implementation for subnet size validation
FileSystemCheckSubnetOptions.cs Options class defining command parameters
AzureManagedLustreService.cs Service method to perform Azure API validation calls
IAzureManagedLustreService.cs Interface definition for the new validation method
AzureManagedLustreOptionDefinitions.cs Command-line option definitions for subnet-id and location
AzureManagedLustreJsonContext.cs JSON serialization context registration
AzureManagedLustreSetup.cs Command registration with the command system
FileSystemCheckSubnetCommandTests.cs Unit tests for the new command
AzureManagedLustreCommandTests.cs Live integration tests
test-resources.bicep Test infrastructure updates with standardized output names
README.md Documentation example for the new command
CHANGELOG.md Release notes for the new feature
azmcp-commands.md Command reference documentation

Comment thread docs/azmcp-commands.md Outdated
Comment thread docs/azmcp-commands.md Outdated
Comment thread tools/Azure.Mcp.Tools.AzureManagedLustre/src/AzureManagedLustreSetup.cs Outdated
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch from 02d4f16 to 9582e31 Compare September 5, 2025 15:29
Comment thread docs/azmcp-commands.md Outdated
Comment thread tools/Azure.Mcp.Tools.AzureManagedLustre/src/AzureManagedLustreSetup.cs Outdated
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch from 0e82782 to dc251ed Compare September 5, 2025 20:44
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch 2 times, most recently from 7c90994 to df2ab74 Compare September 10, 2025 16:56
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch 2 times, most recently from 3b939df to f0ed09b Compare September 11, 2025 17:50
Comment thread servers/Azure.Mcp.Server/CHANGELOG.md Outdated
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch 2 times, most recently from e3ad27c to 7469e42 Compare September 15, 2025 18:55
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch from 7469e42 to 151112b Compare September 16, 2025 14:40
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch 4 times, most recently from 1cc872b to 575f82b Compare September 24, 2025 21:00
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch 2 times, most recently from dd96a3d to 68e827f Compare September 27, 2025 09:19
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch from 68e827f to 8283489 Compare September 29, 2025 14:06
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch from 8283489 to 0e575eb Compare October 3, 2025 14:44
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch from 0e575eb to d340423 Compare October 3, 2025 18:15
@wolfgang-desalvador wolfgang-desalvador force-pushed the wdesalvador/AzureManagedLustreFileSystemCheckSubnetSize branch from b762925 to 97cd9db Compare October 6, 2025 16:21
@alzimmermsft alzimmermsft merged commit 42fbb8b into microsoft:main Oct 6, 2025
26 checks passed
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-Azure.Mcp Azure.Mcp.Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants