Add Azure Managed Lustre Filesystem Check Subnet Size#111
Merged
alzimmermsft merged 1 commit intomicrosoft:mainfrom Oct 6, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Azure Managed Lustre command check-subnet-size that validates whether a subnet can host an Azure Managed Lustre filesystem for a given SKU and size. The command helps users verify subnet capacity before attempting to create AMLFS instances.
Key changes:
- Implements subnet validation logic for AMLFS deployments
- Adds comprehensive unit and live tests for the new functionality
- Updates documentation and command registration
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| FileSystemCheckSubnetCommand.cs | Core command implementation for subnet size validation |
| FileSystemCheckSubnetOptions.cs | Options class defining command parameters |
| AzureManagedLustreService.cs | Service method to perform Azure API validation calls |
| IAzureManagedLustreService.cs | Interface definition for the new validation method |
| AzureManagedLustreOptionDefinitions.cs | Command-line option definitions for subnet-id and location |
| AzureManagedLustreJsonContext.cs | JSON serialization context registration |
| AzureManagedLustreSetup.cs | Command registration with the command system |
| FileSystemCheckSubnetCommandTests.cs | Unit tests for the new command |
| AzureManagedLustreCommandTests.cs | Live integration tests |
| test-resources.bicep | Test infrastructure updates with standardized output names |
| README.md | Documentation example for the new command |
| CHANGELOG.md | Release notes for the new feature |
| azmcp-commands.md | Command reference documentation |
alzimmermsft
reviewed
Sep 4, 2025
jongio
requested changes
Sep 4, 2025
02d4f16 to
9582e31
Compare
jongio
requested changes
Sep 5, 2025
0e82782 to
dc251ed
Compare
jongio
approved these changes
Sep 8, 2025
7c90994 to
df2ab74
Compare
3b939df to
f0ed09b
Compare
alzimmermsft
approved these changes
Sep 11, 2025
jongio
approved these changes
Sep 11, 2025
e3ad27c to
7469e42
Compare
KinoriSR
approved these changes
Sep 16, 2025
7469e42 to
151112b
Compare
jongio
reviewed
Sep 16, 2025
1cc872b to
575f82b
Compare
dd96a3d to
68e827f
Compare
alzimmermsft
approved these changes
Sep 29, 2025
68e827f to
8283489
Compare
alzimmermsft
approved these changes
Sep 29, 2025
8283489 to
0e575eb
Compare
alzimmermsft
approved these changes
Oct 3, 2025
0e575eb to
d340423
Compare
alzimmermsft
approved these changes
Oct 3, 2025
b762925 to
97cd9db
Compare
alzimmermsft
approved these changes
Oct 6, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the following Azure Managed Lustre commands:
azmcp-azuremanagedlustre-filesystem-check-subnet-size: Get information about Azure Managed Lustre SKU [#110]GitHub issue number?
Relates to:
azmcp azuremanagedlustre filesystem check-subnet-sizePre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/docs/e2eTestPrompts.mdeng/tools/ToolDescriptionEvaluatortool and obtained a result >= 0.4