Skip to content

Merge Kubernetes get and list tools#591

Merged
alzimmermsft merged 11 commits intomicrosoft:mainfrom
alzimmermsft:MergeAksTools
Oct 7, 2025
Merged

Merge Kubernetes get and list tools#591
alzimmermsft merged 11 commits intomicrosoft:mainfrom
alzimmermsft:MergeAksTools

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

Merges Azure Kubernetes Service get and list tools.

GitHub issue number?

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 30, 2025
@joshfree joshfree added this to the 2025-09 milestone Sep 30, 2025
@alzimmermsft alzimmermsft modified the milestones: 2025-09, 2025-10 Oct 6, 2025
@alzimmermsft alzimmermsft marked this pull request as ready for review October 7, 2025 17:17
Copilot AI review requested due to automatic review settings October 7, 2025 17:17
@alzimmermsft alzimmermsft requested review from a team, feiskyer, gossion and qianwens as code owners October 7, 2025 17:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges Azure Kubernetes Service (AKS) get and list tools to consolidate functionality and reduce the number of commands. Instead of having separate get and list commands, the get commands now perform both operations based on optional parameters.

Key changes:

  • Merged azmcp_aks_cluster_list into azmcp_aks_cluster_get - now returns all clusters when no cluster name is provided
  • Merged azmcp_aks_nodepool_list into azmcp_aks_nodepool_get - now returns all node pools when no nodepool name is provided

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.Quota/src/Services/Util/Usage/NetworkUsageChecker.cs Removes unnecessary parentheses around cast operations
tools/Azure.Mcp.Tools.Quota/src/Services/Util/AzureUsageChecker.cs Modernizes collection initialization syntax
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.UnitTests/Nodepool/NodepoolListCommandTests.cs Removes obsolete test file for list command
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.UnitTests/Nodepool/NodepoolGetCommandTests.cs Updates tests to use merged get functionality
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.UnitTests/Cluster/ClusterListCommandTests.cs Removes obsolete test file for list command
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.UnitTests/Cluster/ClusterGetCommandTests.cs Updates tests to use merged get functionality
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/NodepoolGetCommandTests.cs Updates live tests for merged functionality
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/NodepoolCommandTests.cs Updates live tests to use get command
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/AksCommandTests.cs Updates live tests to use get command
tools/Azure.Mcp.Tools.Aks/src/Services/IAksService.cs Merges service interfaces for get and list operations
tools/Azure.Mcp.Tools.Aks/src/Services/AksService.cs Implements merged functionality in service layer
tools/Azure.Mcp.Tools.Aks/src/Options/Nodepool/NodepoolListOptions.cs Removes obsolete options class
tools/Azure.Mcp.Tools.Aks/src/Options/Cluster/ClusterListOptions.cs Removes obsolete options class
tools/Azure.Mcp.Tools.Aks/src/Options/AksOptionDefinitions.cs Makes options non-required to support merged functionality
tools/Azure.Mcp.Tools.Aks/src/Commands/Nodepool/NodepoolListCommand.cs Removes obsolete command file
tools/Azure.Mcp.Tools.Aks/src/Commands/Nodepool/NodepoolGetCommand.cs Updates to handle both get and list operations
tools/Azure.Mcp.Tools.Aks/src/Commands/Cluster/ClusterListCommand.cs Removes obsolete command file
tools/Azure.Mcp.Tools.Aks/src/Commands/Cluster/ClusterGetCommand.cs Updates to handle both get and list operations
tools/Azure.Mcp.Tools.Aks/src/Commands/AksJsonContext.cs Removes obsolete serialization contexts
tools/Azure.Mcp.Tools.Aks/src/AksSetup.cs Updates service registration to remove list commands
servers/Azure.Mcp.Server/CHANGELOG.md Documents breaking changes
eng/tools/ToolDescriptionEvaluator/tools.json Updates tool descriptions and removes list commands
eng/tools/ToolDescriptionEvaluator/prompts.json Updates test prompts for merged commands
docs/e2eTestPrompts.md Updates end-to-end test prompts
docs/azmcp-commands.md Updates documentation for merged commands

Comment thread tools/Azure.Mcp.Tools.Aks/src/Services/AksService.cs
Comment thread tools/Azure.Mcp.Tools.Aks/src/Services/AksService.cs
@alzimmermsft alzimmermsft merged commit 9288053 into microsoft:main Oct 7, 2025
27 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Oct 7, 2025
@alzimmermsft alzimmermsft deleted the MergeAksTools branch October 7, 2025 21:14
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Dec 8, 2025
* Initial update to merge tools

* Update CHANGELOG

* Descriptio tweaks

* Fix linting and tests

* Checkpoint changes

* Fix resource group requiredness when listing

* Finalize test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants