TextBox right border is clipped w/ smaller Width set

[adrientetar]

Describe the bug

TextBox right border gets clipped if a small enough (e.g. <=60) width is set:

Previously reported here: https://developercommunity.visualstudio.com/content/problem/535762/uwp-textbox-width-clipping.html

Steps to reproduce the bug

1. Create a page and put <TextBox AcceptsReturn="True" Width="60" /> in it
2. Visualize it

Expected behavior

Right border is visible.

Version Info

NuGet package version:

Windows 10 version	Saw the problem?
Insider Build (xxxxx)
October 2018 Update (17763)	X
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Anniversary Update (14393)

Device form factor	Saw the problem?
Desktop	X
Mobile
Xbox
Surface Hub
IoT

Additional context

[MikeHillberg]

I don't see that behavior with the repro as written. But I do see it if the width of the parent is set to 60.

I think what you're seeing is that TextBox's MinWidth is 64, so a width <=63 can cause a clip. You can fix it by setting the MinWidth smaller.

[adrientetar]

@MikeHillberg Well, I'm seeing this even is parent's width is larger, and setting MinWidth does not remove the clipping for me:

[mrlacey]

The issue is with the definition of the internal border in TextBox_themeresources.xaml

Note, the clipping described in this issue is also seen when setting a MinHeight less than 34.

The Border has the MinWidth and MinHeight using Theme Resources which can't be overridden [source]

                        <Border x:Name="BorderElement"
                            …
                            MinWidth="{ThemeResource TextControlThemeMinWidth}"
                            MinHeight="{ThemeResource TextControlThemeMinHeight}" />

As a temporary workaround in your app, re-templating the control with TemplateBinding to the outer properties seems to work.

        MinHeight="{TemplateBinding MinHeight}"
        MinWidth="{TemplateBinding MinWidth}"

You can see the consequence of changing to using TemplateBinding in the image below.

I don't know the full consequences of changing this in the source though. Someone with better knowledge of the internals of this control will hopefully be able to advise.

[jevansaks]

This might have been introduced when doing compact density. What you're doing should work. @chrisglein to investigate.

[msft-github-bot]

🎉This issue was addressed in #1344, which has now been successfully released as Microsoft.UI.Xaml v2.3.191007001-prerelease.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[msft-github-bot]

🎉This issue was addressed in #1344, which has now been successfully released as Microsoft.UI.Xaml v2.3.191129002.:tada:

Handy links:

• Release Notes
• Official Nuget Release